mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: clang-built-linux <clang-built-linux@googlegroups.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] .clang-format: Remove conditional comments
Date: Tue, 03 Nov 2020 20:16:59 -0800	[thread overview]
Message-ID: <1de8953aba13bcd4c9643bae61af2081e33f071f.camel@perches.com> (raw)
In-Reply-To: <CANiq72k11+VO-igyHRakJEGuSmsDJyQCpYDVeNxZwRt62yCFXQ@mail.gmail.com>

On Wed, 2020-11-04 at 04:57 +0100, Miguel Ojeda wrote:
> On Wed, Nov 4, 2020 at 4:15 AM Joe Perches <joe@perches.com> wrote:
> > 
> > No one ever will use clang-format on the current kernel sources
> > without having a recent version of clang and clang-format.
> 
> Why? Many distros come with clang-format pre-packaged, and in fact the
> original patch (that you commented on) argued for the >= 4 requirement
> that way.

The current kernel is v5.10 which requires clang 10.0 or higher.
This patch is for the current kernel.

This patch is not to be applied or backported to old kernels so no
person is going to use this patch on any old or backported kernel.

If a person is going to use clang-format on the current kernel sources
unless they are developing for the current kernel.

They are going to have to be using clang 10.0 or higher and therefore
also will have and be using clang-format 10.0 or higher.

Take it or not, apply it or not.  I don't use clang-format and unless
there are improvements to it, I imagine I'll continue to use emacs
indent-region and a few other reformatting tools instead.

cheers, Joe


  reply	other threads:[~2020-11-04  4:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-03 18:29 Joe Perches
2020-11-03 21:33 ` Miguel Ojeda
2020-11-04  0:56   ` Joe Perches
2020-11-04  3:10     ` Miguel Ojeda
2020-11-04  3:15       ` Joe Perches
2020-11-04  3:57         ` Miguel Ojeda
2020-11-04  4:16           ` Joe Perches [this message]
2020-11-04  5:24             ` Miguel Ojeda
2020-11-04  1:08   ` Nick Desaulniers
2020-11-04  1:31     ` Joe Perches
2020-11-05  0:35       ` Nick Desaulniers
2020-11-05  6:44         ` Miguel Ojeda
2020-11-05  7:08           ` Joe Perches
2020-11-04  3:40     ` Miguel Ojeda
2020-11-05  0:33       ` Nick Desaulniers
2020-11-05  5:10         ` Miguel Ojeda
2020-11-04  1:11 ` Nick Desaulniers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1de8953aba13bcd4c9643bae61af2081e33f071f.camel@perches.com \
    --to=joe@perches.com \
    --cc=clang-built-linux@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®