From: Johannes Berg <johannes@sipsolutions.net>
To: Youghandhar Chintala <quic_youghand@quicinc.com>,
ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_mpubbise@quicinc.com
Subject: Re: [PATCH 1/2] wifi: cfg80211: Add beacon hint notifier support
Date: Wed, 18 Jan 2023 17:30:11 +0100 [thread overview]
Message-ID: <1df59863e78e8ddbe7eb3a74e6dd4c8f0bd7f098.camel@sipsolutions.net> (raw)
In-Reply-To: <20221222124221.30894-2-quic_youghand@quicinc.com>
> +++ b/include/net/cfg80211.h
> @@ -5386,6 +5386,8 @@ struct wiphy {
> void (*reg_notifier)(struct wiphy *wiphy,
> struct regulatory_request *request);
>
> + void (*beacon_hint_notifier)(struct wiphy *wiphy);
missing documentation, for sure
Also this should probably be in the ops, rather than here? Not sure why
reg_notifier is here.
> - if (channel_changed)
> + if (channel_changed) {
> nl80211_send_beacon_hint_event(wiphy, &chan_before, chan);
> + if (wiphy->beacon_hint_notifier)
> + wiphy->beacon_hint_notifier(wiphy);
> + }
This also seems excessive if you're not even passing the channel - you
call it for every (affected) channel, but you don't tell it anything
about the channel? Seems strange.
However ...
Why is this even needed? You should always get reg_notifier after this
anyway?
johannes
next prev parent reply other threads:[~2023-01-18 16:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 12:42 [PATCH 0/2] Update the channel list if the change in channel flags Youghandhar Chintala
2022-12-22 12:42 ` [PATCH 1/2] wifi: cfg80211: Add beacon hint notifier support Youghandhar Chintala
2023-01-18 16:30 ` Johannes Berg [this message]
2023-02-15 11:26 ` Youghandhar Chintala (Temp)
2023-02-15 15:10 ` Johannes Berg
2023-02-22 0:22 ` Wen Gong
2023-02-22 8:00 ` Johannes Berg
2022-12-22 12:42 ` [PATCH 2/2] wifi: ath10k: update the channel list if change in channel flags Youghandhar Chintala
2023-01-19 2:26 ` Wen Gong
2023-01-19 5:47 ` Youghandhar Chintala (Temp)
2022-12-22 14:00 ` [PATCH 0/2] Update the channel list if the " Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2022-12-22 12:05 Youghandhar Chintala
2022-12-22 12:05 ` [PATCH 1/2] wifi: cfg80211: Add beacon hint notifier support Youghandhar Chintala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1df59863e78e8ddbe7eb3a74e6dd4c8f0bd7f098.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath10k@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_mpubbise@quicinc.com \
--cc=quic_youghand@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®