From: Johannes Berg <johannes@sipsolutions.net>
To: Wen Gong <quic_wgong@quicinc.com>,
"Youghandhar Chintala (Temp)" <quic_youghand@quicinc.com>,
ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_mpubbise@quicinc.com
Subject: Re: [PATCH 1/2] wifi: cfg80211: Add beacon hint notifier support
Date: Wed, 22 Feb 2023 09:00:59 +0100 [thread overview]
Message-ID: <934e866942bd8d413bbb4570741e5d8d1537f211.camel@sipsolutions.net> (raw)
In-Reply-To: <9ae693f2-b19e-ff1f-851c-c3d09db4d9d1@quicinc.com>
On Wed, 2023-02-22 at 08:22 +0800, Wen Gong wrote:
> On 2/15/2023 11:10 PM, Johannes Berg wrote:
> > > > Why is this even needed? You should always get reg_notifier after this
> > > > anyway?
> > > Currently when channel flag changed through the beacon hints are not
> > > informed to driver.
> > >
> > > reg_notifier will be triggered for regdomain changes but not for channel flag changes due to beacon hints.
> > >
> > So maybe triggering reg notifier once would be sufficient, a la Wen's
> > patch that I recently merged?
>
> My patch only take effect for this flag, not for all wiphy.
>
> if (wiphy->flags & WIPHY_FLAG_NOTIFY_REGDOM_BY_DRIVER)
>
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit?id=d99975c4953eb79e389d4630e848435c700e2dfc
>
Oh sure, I meant this patch could do something similar, instead of
introducing a new notifier callback.
johannes
next prev parent reply other threads:[~2023-02-22 8:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 12:42 [PATCH 0/2] Update the channel list if the change in channel flags Youghandhar Chintala
2022-12-22 12:42 ` [PATCH 1/2] wifi: cfg80211: Add beacon hint notifier support Youghandhar Chintala
2023-01-18 16:30 ` Johannes Berg
2023-02-15 11:26 ` Youghandhar Chintala (Temp)
2023-02-15 15:10 ` Johannes Berg
2023-02-22 0:22 ` Wen Gong
2023-02-22 8:00 ` Johannes Berg [this message]
2022-12-22 12:42 ` [PATCH 2/2] wifi: ath10k: update the channel list if change in channel flags Youghandhar Chintala
2023-01-19 2:26 ` Wen Gong
2023-01-19 5:47 ` Youghandhar Chintala (Temp)
2022-12-22 14:00 ` [PATCH 0/2] Update the channel list if the " Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2022-12-22 12:05 Youghandhar Chintala
2022-12-22 12:05 ` [PATCH 1/2] wifi: cfg80211: Add beacon hint notifier support Youghandhar Chintala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=934e866942bd8d413bbb4570741e5d8d1537f211.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath10k@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_mpubbise@quicinc.com \
--cc=quic_wgong@quicinc.com \
--cc=quic_youghand@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®