* [PATCH 1/3] arm64: dts: qcom: sm8350-hdk: include PMK8350
@ 2023-06-16 19:02 Krzysztof Kozlowski
2023-06-16 19:02 ` [PATCH 2/3] arm64: dts: qcom: sm8350-hdk: add uSD card Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2023-06-16 19:02 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
HDK8350 comes with PMK8350 PMIC, so include relevant DTSI. This also
allows to use reboot reason.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
index d33338e9a95f..de67438b3a97 100644
--- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
@@ -7,6 +7,7 @@
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
#include "sm8350.dtsi"
+#include "pmk8350.dtsi"
/ {
model = "Qualcomm Technologies, Inc. SM8350 HDK";
--
2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH 2/3] arm64: dts: qcom: sm8350-hdk: add uSD card 2023-06-16 19:02 [PATCH 1/3] arm64: dts: qcom: sm8350-hdk: include PMK8350 Krzysztof Kozlowski @ 2023-06-16 19:02 ` Krzysztof Kozlowski 2023-06-19 13:19 ` Konrad Dybcio 2023-06-16 19:02 ` [PATCH 3/3] arm64: dts: qcom: sm8350: add APR and LPASS TLMM Krzysztof Kozlowski 2023-06-19 13:19 ` [PATCH 1/3] arm64: dts: qcom: sm8350-hdk: include PMK8350 Konrad Dybcio 2 siblings, 1 reply; 9+ messages in thread From: Krzysztof Kozlowski @ 2023-06-16 19:02 UTC (permalink / raw) To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel Cc: Krzysztof Kozlowski Add uSD card to HDK8350. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts index de67438b3a97..997f892a0f3a 100644 --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts @@ -475,6 +475,18 @@ &qupv3_id_2 { status = "okay"; }; +&sdhc_2 { + cd-gpios = <&tlmm 92 GPIO_ACTIVE_HIGH>; + pinctrl-names = "default", "sleep"; + pinctrl-0 = <&sdc2_default_state &sdc2_card_det_n>; + pinctrl-1 = <&sdc2_sleep_state &sdc2_card_det_n>; + vmmc-supply = <&vreg_l9c_2p96>; + vqmmc-supply = <&vreg_l6c_1p8>; + no-sdio; + no-mmc; + status = "okay"; +}; + &slpi { status = "okay"; firmware-name = "qcom/sm8350/slpi.mbn"; @@ -733,6 +745,13 @@ wake-pins { bias-pull-up; }; }; + + sdc2_card_det_n: sd-card-det-n-state { + pins = "gpio92"; + function = "gpio"; + drive-strength = <2>; + bias-pull-up; + }; }; &uart2 { -- 2.34.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] arm64: dts: qcom: sm8350-hdk: add uSD card 2023-06-16 19:02 ` [PATCH 2/3] arm64: dts: qcom: sm8350-hdk: add uSD card Krzysztof Kozlowski @ 2023-06-19 13:19 ` Konrad Dybcio 0 siblings, 0 replies; 9+ messages in thread From: Konrad Dybcio @ 2023-06-19 13:19 UTC (permalink / raw) To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel On 16.06.2023 21:02, Krzysztof Kozlowski wrote: > Add uSD card to HDK8350. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > index de67438b3a97..997f892a0f3a 100644 > --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > @@ -475,6 +475,18 @@ &qupv3_id_2 { > status = "okay"; > }; > > +&sdhc_2 { > + cd-gpios = <&tlmm 92 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sdc2_default_state &sdc2_card_det_n>; > + pinctrl-1 = <&sdc2_sleep_state &sdc2_card_det_n>; > + vmmc-supply = <&vreg_l9c_2p96>; > + vqmmc-supply = <&vreg_l6c_1p8>; > + no-sdio; > + no-mmc; > + status = "okay"; > +}; > + > &slpi { > status = "okay"; > firmware-name = "qcom/sm8350/slpi.mbn"; > @@ -733,6 +745,13 @@ wake-pins { > bias-pull-up; > }; > }; > + > + sdc2_card_det_n: sd-card-det-n-state { > + pins = "gpio92"; > + function = "gpio"; > + drive-strength = <2>; > + bias-pull-up; > + }; > }; > > &uart2 { ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/3] arm64: dts: qcom: sm8350: add APR and LPASS TLMM 2023-06-16 19:02 [PATCH 1/3] arm64: dts: qcom: sm8350-hdk: include PMK8350 Krzysztof Kozlowski 2023-06-16 19:02 ` [PATCH 2/3] arm64: dts: qcom: sm8350-hdk: add uSD card Krzysztof Kozlowski @ 2023-06-16 19:02 ` Krzysztof Kozlowski 2023-06-19 13:24 ` Konrad Dybcio 2023-06-19 13:19 ` [PATCH 1/3] arm64: dts: qcom: sm8350-hdk: include PMK8350 Konrad Dybcio 2 siblings, 1 reply; 9+ messages in thread From: Krzysztof Kozlowski @ 2023-06-16 19:02 UTC (permalink / raw) To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel Cc: Krzysztof Kozlowski Add audio-related nodes: the APR in the ADSP (same as on SM8250) and LPASS TLMM pin controller. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Bindings for SM8350: https://lore.kernel.org/linux-arm-msm/20230616185742.2250452-1-krzysztof.kozlowski@linaro.org/T/#t --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 82 ++++++++++++++++++++++++++++ 1 file changed, 82 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi index 33b7ef8fd78a..9650cecb1370 100644 --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi @@ -15,7 +15,9 @@ #include <dt-bindings/mailbox/qcom-ipcc.h> #include <dt-bindings/phy/phy-qcom-qmp.h> #include <dt-bindings/power/qcom-rpmpd.h> +#include <dt-bindings/soc/qcom,apr.h> #include <dt-bindings/soc/qcom,rpmh-rsc.h> +#include <dt-bindings/sound/qcom,q6afe.h> #include <dt-bindings/thermal/thermal.h> #include <dt-bindings/interconnect/qcom,sm8350.h> @@ -1780,6 +1782,20 @@ tcsr_mutex: hwlock@1f40000 { #hwlock-cells = <1>; }; + lpass_tlmm: pinctrl@33c0000 { + compatible = "qcom,sm8350-lpass-lpi-pinctrl"; + reg = <0 0x033c0000 0x0 0x20000>, + <0 0x03550000 0x0 0x10000>; + + clocks = <&q6afecc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>, + <&q6afecc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>; + clock-names = "core", "audio"; + + gpio-controller; + #gpio-cells = <2>; + gpio-ranges = <&lpass_tlmm 0 0 15>; + }; + gpu: gpu@3d00000 { compatible = "qcom,adreno-660.1", "qcom,adreno"; @@ -3189,6 +3205,72 @@ IPCC_MPROC_SIGNAL_GLINK_QMP label = "lpass"; qcom,remote-pid = <2>; + apr { + compatible = "qcom,apr-v2"; + qcom,glink-channels = "apr_audio_svc"; + qcom,domain = <APR_DOMAIN_ADSP>; + #address-cells = <1>; + #size-cells = <0>; + + service@3 { + reg = <APR_SVC_ADSP_CORE>; + compatible = "qcom,q6core"; + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; + }; + + q6afe: service@4 { + compatible = "qcom,q6afe"; + reg = <APR_SVC_AFE>; + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; + q6afedai: dais { + compatible = "qcom,q6afe-dais"; + #address-cells = <1>; + #size-cells = <0>; + #sound-dai-cells = <1>; + }; + + q6afecc: clock-controller { + compatible = "qcom,q6afe-clocks"; + #clock-cells = <2>; + }; + }; + + q6asm: service@7 { + compatible = "qcom,q6asm"; + reg = <APR_SVC_ASM>; + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; + q6asmdai: dais { + compatible = "qcom,q6asm-dais"; + #address-cells = <1>; + #size-cells = <0>; + #sound-dai-cells = <1>; + iommus = <&apps_smmu 0x1801 0x0>; + + dai@0 { + reg = <0>; + }; + + dai@1 { + reg = <1>; + }; + + dai@2 { + reg = <2>; + }; + }; + }; + + q6adm: service@8 { + compatible = "qcom,q6adm"; + reg = <APR_SVC_ADM>; + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; + q6routing: routing { + compatible = "qcom,q6adm-routing"; + #sound-dai-cells = <0>; + }; + }; + }; + fastrpc { compatible = "qcom,fastrpc"; qcom,glink-channels = "fastrpcglink-apps-dsp"; -- 2.34.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3/3] arm64: dts: qcom: sm8350: add APR and LPASS TLMM 2023-06-16 19:02 ` [PATCH 3/3] arm64: dts: qcom: sm8350: add APR and LPASS TLMM Krzysztof Kozlowski @ 2023-06-19 13:24 ` Konrad Dybcio 2023-06-19 14:37 ` Krzysztof Kozlowski 0 siblings, 1 reply; 9+ messages in thread From: Konrad Dybcio @ 2023-06-19 13:24 UTC (permalink / raw) To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel On 16.06.2023 21:02, Krzysztof Kozlowski wrote: > Add audio-related nodes: the APR in the ADSP (same as on SM8250) and > LPASS TLMM pin controller. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Bindings for SM8350: > https://lore.kernel.org/linux-arm-msm/20230616185742.2250452-1-krzysztof.kozlowski@linaro.org/T/#t > --- > arch/arm64/boot/dts/qcom/sm8350.dtsi | 82 ++++++++++++++++++++++++++++ > 1 file changed, 82 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi > index 33b7ef8fd78a..9650cecb1370 100644 > --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi > @@ -15,7 +15,9 @@ > #include <dt-bindings/mailbox/qcom-ipcc.h> > #include <dt-bindings/phy/phy-qcom-qmp.h> > #include <dt-bindings/power/qcom-rpmpd.h> > +#include <dt-bindings/soc/qcom,apr.h> > #include <dt-bindings/soc/qcom,rpmh-rsc.h> > +#include <dt-bindings/sound/qcom,q6afe.h> > #include <dt-bindings/thermal/thermal.h> > #include <dt-bindings/interconnect/qcom,sm8350.h> > > @@ -1780,6 +1782,20 @@ tcsr_mutex: hwlock@1f40000 { > #hwlock-cells = <1>; > }; > > + lpass_tlmm: pinctrl@33c0000 { > + compatible = "qcom,sm8350-lpass-lpi-pinctrl"; > + reg = <0 0x033c0000 0x0 0x20000>, '0' for addr, '0x0' for size :/ The rest of the file uses '0', please do that > + <0 0x03550000 0x0 0x10000>; > + > + clocks = <&q6afecc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>, > + <&q6afecc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>; > + clock-names = "core", "audio"; > + > + gpio-controller; > + #gpio-cells = <2>; > + gpio-ranges = <&lpass_tlmm 0 0 15>; > + }; > + > gpu: gpu@3d00000 { > compatible = "qcom,adreno-660.1", "qcom,adreno"; > > @@ -3189,6 +3205,72 @@ IPCC_MPROC_SIGNAL_GLINK_QMP > label = "lpass"; > qcom,remote-pid = <2>; > > + apr { > + compatible = "qcom,apr-v2"; > + qcom,glink-channels = "apr_audio_svc"; > + qcom,domain = <APR_DOMAIN_ADSP>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + service@3 { > + reg = <APR_SVC_ADSP_CORE>; > + compatible = "qcom,q6core"; > + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; > + }; > + > + q6afe: service@4 { > + compatible = "qcom,q6afe"; > + reg = <APR_SVC_AFE>; > + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; Missing newline before subnodes > + q6afedai: dais { > + compatible = "qcom,q6afe-dais"; > + #address-cells = <1>; > + #size-cells = <0>; > + #sound-dai-cells = <1>; > + }; > + > + q6afecc: clock-controller { > + compatible = "qcom,q6afe-clocks"; > + #clock-cells = <2>; > + }; > + }; > + > + q6asm: service@7 { > + compatible = "qcom,q6asm"; > + reg = <APR_SVC_ASM>; > + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; ditto > + q6asmdai: dais { > + compatible = "qcom,q6asm-dais"; > + #address-cells = <1>; > + #size-cells = <0>; > + #sound-dai-cells = <1>; > + iommus = <&apps_smmu 0x1801 0x0>; > + > + dai@0 { > + reg = <0>; > + }; > + > + dai@1 { > + reg = <1>; > + }; > + > + dai@2 { > + reg = <2>; > + }; > + }; > + }; > + > + q6adm: service@8 { > + compatible = "qcom,q6adm"; > + reg = <APR_SVC_ADM>; > + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; ditto The rest looks ok I think Konrad > + q6routing: routing { > + compatible = "qcom,q6adm-routing"; > + #sound-dai-cells = <0>; > + }; > + }; > + }; > + > fastrpc { > compatible = "qcom,fastrpc"; > qcom,glink-channels = "fastrpcglink-apps-dsp"; ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3/3] arm64: dts: qcom: sm8350: add APR and LPASS TLMM 2023-06-19 13:24 ` Konrad Dybcio @ 2023-06-19 14:37 ` Krzysztof Kozlowski 2023-06-19 14:45 ` Konrad Dybcio 0 siblings, 1 reply; 9+ messages in thread From: Krzysztof Kozlowski @ 2023-06-19 14:37 UTC (permalink / raw) To: Konrad Dybcio, Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel On 19/06/2023 15:24, Konrad Dybcio wrote: > On 16.06.2023 21:02, Krzysztof Kozlowski wrote: >> Add audio-related nodes: the APR in the ADSP (same as on SM8250) and >> LPASS TLMM pin controller. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> --- >> >> Bindings for SM8350: >> https://lore.kernel.org/linux-arm-msm/20230616185742.2250452-1-krzysztof.kozlowski@linaro.org/T/#t >> --- >> arch/arm64/boot/dts/qcom/sm8350.dtsi | 82 ++++++++++++++++++++++++++++ >> 1 file changed, 82 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi >> index 33b7ef8fd78a..9650cecb1370 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi >> @@ -15,7 +15,9 @@ >> #include <dt-bindings/mailbox/qcom-ipcc.h> >> #include <dt-bindings/phy/phy-qcom-qmp.h> >> #include <dt-bindings/power/qcom-rpmpd.h> >> +#include <dt-bindings/soc/qcom,apr.h> >> #include <dt-bindings/soc/qcom,rpmh-rsc.h> >> +#include <dt-bindings/sound/qcom,q6afe.h> >> #include <dt-bindings/thermal/thermal.h> >> #include <dt-bindings/interconnect/qcom,sm8350.h> >> >> @@ -1780,6 +1782,20 @@ tcsr_mutex: hwlock@1f40000 { >> #hwlock-cells = <1>; >> }; >> >> + lpass_tlmm: pinctrl@33c0000 { >> + compatible = "qcom,sm8350-lpass-lpi-pinctrl"; >> + reg = <0 0x033c0000 0x0 0x20000>, > '0' for addr, '0x0' for size :/ > > The rest of the file uses '0', please do that It's a mixture but mostly 0x0 in both places. I don't mind switching to 0. > >> + <0 0x03550000 0x0 0x10000>; >> + >> + clocks = <&q6afecc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>, >> + <&q6afecc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>; >> + clock-names = "core", "audio"; >> + >> + gpio-controller; >> + #gpio-cells = <2>; >> + gpio-ranges = <&lpass_tlmm 0 0 15>; >> + }; >> + >> gpu: gpu@3d00000 { >> compatible = "qcom,adreno-660.1", "qcom,adreno"; >> >> @@ -3189,6 +3205,72 @@ IPCC_MPROC_SIGNAL_GLINK_QMP >> label = "lpass"; >> qcom,remote-pid = <2>; >> >> + apr { >> + compatible = "qcom,apr-v2"; >> + qcom,glink-channels = "apr_audio_svc"; >> + qcom,domain = <APR_DOMAIN_ADSP>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + service@3 { >> + reg = <APR_SVC_ADSP_CORE>; >> + compatible = "qcom,q6core"; >> + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; >> + }; >> + >> + q6afe: service@4 { >> + compatible = "qcom,q6afe"; >> + reg = <APR_SVC_AFE>; >> + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; > Missing newline before subnodes acks Best regards, Krzysztof ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3/3] arm64: dts: qcom: sm8350: add APR and LPASS TLMM 2023-06-19 14:37 ` Krzysztof Kozlowski @ 2023-06-19 14:45 ` Konrad Dybcio 0 siblings, 0 replies; 9+ messages in thread From: Konrad Dybcio @ 2023-06-19 14:45 UTC (permalink / raw) To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel On 19.06.2023 16:37, Krzysztof Kozlowski wrote: > On 19/06/2023 15:24, Konrad Dybcio wrote: >> On 16.06.2023 21:02, Krzysztof Kozlowski wrote: >>> Add audio-related nodes: the APR in the ADSP (same as on SM8250) and >>> LPASS TLMM pin controller. >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> >>> --- >>> >>> Bindings for SM8350: >>> https://lore.kernel.org/linux-arm-msm/20230616185742.2250452-1-krzysztof.kozlowski@linaro.org/T/#t >>> --- >>> arch/arm64/boot/dts/qcom/sm8350.dtsi | 82 ++++++++++++++++++++++++++++ >>> 1 file changed, 82 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi >>> index 33b7ef8fd78a..9650cecb1370 100644 >>> --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi >>> @@ -15,7 +15,9 @@ >>> #include <dt-bindings/mailbox/qcom-ipcc.h> >>> #include <dt-bindings/phy/phy-qcom-qmp.h> >>> #include <dt-bindings/power/qcom-rpmpd.h> >>> +#include <dt-bindings/soc/qcom,apr.h> >>> #include <dt-bindings/soc/qcom,rpmh-rsc.h> >>> +#include <dt-bindings/sound/qcom,q6afe.h> >>> #include <dt-bindings/thermal/thermal.h> >>> #include <dt-bindings/interconnect/qcom,sm8350.h> >>> >>> @@ -1780,6 +1782,20 @@ tcsr_mutex: hwlock@1f40000 { >>> #hwlock-cells = <1>; >>> }; >>> >>> + lpass_tlmm: pinctrl@33c0000 { >>> + compatible = "qcom,sm8350-lpass-lpi-pinctrl"; >>> + reg = <0 0x033c0000 0x0 0x20000>, >> '0' for addr, '0x0' for size :/ >> >> The rest of the file uses '0', please do that > It's a mixture but mostly 0x0 in both places. I don't mind switching to 0. 0x0 would be preferred (dec makes no sense for registers) but I don't think anybody wants to do (or handle) the mess of replacing that Konrad > >> >>> + <0 0x03550000 0x0 0x10000>; >>> + >>> + clocks = <&q6afecc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>, >>> + <&q6afecc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>; >>> + clock-names = "core", "audio"; >>> + >>> + gpio-controller; >>> + #gpio-cells = <2>; >>> + gpio-ranges = <&lpass_tlmm 0 0 15>; >>> + }; >>> + >>> gpu: gpu@3d00000 { >>> compatible = "qcom,adreno-660.1", "qcom,adreno"; >>> >>> @@ -3189,6 +3205,72 @@ IPCC_MPROC_SIGNAL_GLINK_QMP >>> label = "lpass"; >>> qcom,remote-pid = <2>; >>> >>> + apr { >>> + compatible = "qcom,apr-v2"; >>> + qcom,glink-channels = "apr_audio_svc"; >>> + qcom,domain = <APR_DOMAIN_ADSP>; >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + service@3 { >>> + reg = <APR_SVC_ADSP_CORE>; >>> + compatible = "qcom,q6core"; >>> + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; >>> + }; >>> + >>> + q6afe: service@4 { >>> + compatible = "qcom,q6afe"; >>> + reg = <APR_SVC_AFE>; >>> + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; >> Missing newline before subnodes > > acks > > Best regards, > Krzysztof > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] arm64: dts: qcom: sm8350-hdk: include PMK8350 2023-06-16 19:02 [PATCH 1/3] arm64: dts: qcom: sm8350-hdk: include PMK8350 Krzysztof Kozlowski 2023-06-16 19:02 ` [PATCH 2/3] arm64: dts: qcom: sm8350-hdk: add uSD card Krzysztof Kozlowski 2023-06-16 19:02 ` [PATCH 3/3] arm64: dts: qcom: sm8350: add APR and LPASS TLMM Krzysztof Kozlowski @ 2023-06-19 13:19 ` Konrad Dybcio 2023-06-19 13:21 ` Krzysztof Kozlowski 2 siblings, 1 reply; 9+ messages in thread From: Konrad Dybcio @ 2023-06-19 13:19 UTC (permalink / raw) To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel On 16.06.2023 21:02, Krzysztof Kozlowski wrote: > HDK8350 comes with PMK8350 PMIC, so include relevant DTSI. This also > allows to use reboot reason. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> What about the other ones though? Konrad > arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > index d33338e9a95f..de67438b3a97 100644 > --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts > @@ -7,6 +7,7 @@ > > #include <dt-bindings/regulator/qcom,rpmh-regulator.h> > #include "sm8350.dtsi" > +#include "pmk8350.dtsi" > > / { > model = "Qualcomm Technologies, Inc. SM8350 HDK"; ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] arm64: dts: qcom: sm8350-hdk: include PMK8350 2023-06-19 13:19 ` [PATCH 1/3] arm64: dts: qcom: sm8350-hdk: include PMK8350 Konrad Dybcio @ 2023-06-19 13:21 ` Krzysztof Kozlowski 0 siblings, 0 replies; 9+ messages in thread From: Krzysztof Kozlowski @ 2023-06-19 13:21 UTC (permalink / raw) To: Konrad Dybcio, Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree, linux-kernel On 19/06/2023 15:19, Konrad Dybcio wrote: > On 16.06.2023 21:02, Krzysztof Kozlowski wrote: >> HDK8350 comes with PMK8350 PMIC, so include relevant DTSI. This also >> allows to use reboot reason. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- > Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > What about the other ones though? Step by step. Whoever wants them, adds them I wanted reboot reason, so I added this one. :) Best regards, Krzysztof ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-06-19 14:46 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-06-16 19:02 [PATCH 1/3] arm64: dts: qcom: sm8350-hdk: include PMK8350 Krzysztof Kozlowski 2023-06-16 19:02 ` [PATCH 2/3] arm64: dts: qcom: sm8350-hdk: add uSD card Krzysztof Kozlowski 2023-06-19 13:19 ` Konrad Dybcio 2023-06-16 19:02 ` [PATCH 3/3] arm64: dts: qcom: sm8350: add APR and LPASS TLMM Krzysztof Kozlowski 2023-06-19 13:24 ` Konrad Dybcio 2023-06-19 14:37 ` Krzysztof Kozlowski 2023-06-19 14:45 ` Konrad Dybcio 2023-06-19 13:19 ` [PATCH 1/3] arm64: dts: qcom: sm8350-hdk: include PMK8350 Konrad Dybcio 2023-06-19 13:21 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®