* [PATCH] staging: vc04_services: remove unnecessary NULL check
@ 2023-10-31 8:59 Dan Carpenter
2023-10-31 10:01 ` Umang Jain
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2023-10-31 8:59 UTC (permalink / raw)
To: Florian Fainelli
Cc: Broadcom internal kernel review list, Greg Kroah-Hartman,
Umang Jain, Stefan Wahren, Kieran Bingham, Phil Elwell,
linux-rpi-kernel, linux-arm-kernel, linux-staging, linux-kernel,
kernel-janitors
We ensured that "service" as non-NULL in the previous if statement so
there is no need to check again here.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
index 39b857da2d42..a0117efa2991 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
@@ -2040,8 +2040,7 @@ sync_func(void *v)
continue;
}
- svc_fourcc = service ? service->base.fourcc
- : VCHIQ_MAKE_FOURCC('?', '?', '?', '?');
+ svc_fourcc = service->base.fourcc;
vchiq_log_trace(state->dev, VCHIQ_SYNC,
"Rcvd Msg %s from %p4cc s:%d d:%d len:%d",
--
2.42.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] staging: vc04_services: remove unnecessary NULL check
2023-10-31 8:59 [PATCH] staging: vc04_services: remove unnecessary NULL check Dan Carpenter
@ 2023-10-31 10:01 ` Umang Jain
0 siblings, 0 replies; 2+ messages in thread
From: Umang Jain @ 2023-10-31 10:01 UTC (permalink / raw)
To: Dan Carpenter
Cc: Florian Fainelli, Broadcom internal kernel review list,
Greg Kroah-Hartman, Stefan Wahren, Kieran Bingham, Phil Elwell,
linux-rpi-kernel, linux-arm-kernel, linux-staging, linux-kernel,
kernel-janitors
Hi Dan,
Thank you for the patch.
On Tue, Oct 31, 2023 at 11:59:34AM +0300, Dan Carpenter wrote:
> We ensured that "service" as non-NULL in the previous if statement so
> there is no need to check again here.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
LGTM,
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> index 39b857da2d42..a0117efa2991 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> @@ -2040,8 +2040,7 @@ sync_func(void *v)
> continue;
> }
>
> - svc_fourcc = service ? service->base.fourcc
> - : VCHIQ_MAKE_FOURCC('?', '?', '?', '?');
> + svc_fourcc = service->base.fourcc;
>
> vchiq_log_trace(state->dev, VCHIQ_SYNC,
> "Rcvd Msg %s from %p4cc s:%d d:%d len:%d",
> --
> 2.42.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-31 10:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-31 8:59 [PATCH] staging: vc04_services: remove unnecessary NULL check Dan Carpenter
2023-10-31 10:01 ` Umang Jain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®