From: Thomas Richard <thomas.richard@bootlin.com>
To: Pawel Zalewski <pzalewski@thegoodpenguin.co.uk>,
Lee Jones <lee@kernel.org>, Chen-Yu Tsai <wens@kernel.org>,
David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Zha Qipeng <qipeng.zha@intel.com>,
Qunqin Zhao <zhaoqunqin@loongson.cn>,
Andy Shevchenko <andy@kernel.org>
Cc: mfd@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-sound@vger.kernel.org, patches@opensource.cirrus.com,
linux-crypto@vger.kernel.org,
Charles Keepax <ckeepax@opensource.cirrus.com>
Subject: Re: [PATCH v2 2/2] mfd: Use named initializers for acpi_device_id
Date: Fri, 6 Nov 2026 10:58:17 +0100 [thread overview]
Message-ID: <1e12523f-a294-4f98-93d9-4ea3479d4456@bootlin.com> (raw)
In-Reply-To: <20261104-acpi-mfd-v2-2-64b9dee3baaf@thegoodpenguin.co.uk>
On 11/4/26 5:09 PM, Pawel Zalewski wrote:
> Use a designated initializer for the acpi_device_id fields which makes the
> code more readable and consistent with how lists are initialized in the
> rest of the kernel code base. Also drop explicitly setting fields to 0
> where it is redundant.
>
> Unify the list terminator to have a single space between the brackets and
> no trailing comma.
>
> Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> Signed-off-by: Pawel Zalewski <pzalewski@thegoodpenguin.co.uk>
> ---
> drivers/mfd/axp20x-i2c.c | 2 +-
> drivers/mfd/cs42l43-i2c.c | 8 ++++----
> drivers/mfd/intel_pmc_bxt.c | 2 +-
> drivers/mfd/intel_soc_pmic_bxtwc.c | 2 +-
> drivers/mfd/intel_soc_pmic_chtdc_ti.c | 4 ++--
> drivers/mfd/intel_soc_pmic_chtwc.c | 2 +-
> drivers/mfd/intel_soc_pmic_crc.c | 4 ++--
> drivers/mfd/intel_soc_pmic_mrfld.c | 4 ++--
> drivers/mfd/kempld-core.c | 6 +++---
> drivers/mfd/loongson-se.c | 2 +-
> drivers/mfd/upboard-fpga.c | 6 +++---
Acked-by: Thomas Richard <thomas.richard@bootlin.com> # upboard-fpga.c
Best Regards,
Thomas
prev parent reply other threads:[~2026-11-06 9:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 16:09 [PATCH v2 0/2] mfd: use designated " Pawel Zalewski
2026-11-04 16:09 ` [PATCH v2 1/2] mfd: intel-lpss-acpi: Use named " Pawel Zalewski
2026-11-04 21:36 ` Andy Shevchenko
2026-11-04 16:09 ` [PATCH v2 2/2] mfd: " Pawel Zalewski
2026-11-04 21:37 ` Andy Shevchenko
2026-11-05 7:52 ` Pawel Zalewski
2026-11-05 8:56 ` Andy Shevchenko
2026-11-06 9:58 ` Thomas Richard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e12523f-a294-4f98-93d9-4ea3479d4456@bootlin.com \
--to=thomas.richard@bootlin.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=david.rhodes@cirrus.com \
--cc=lee@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=mika.westerberg@linux.intel.com \
--cc=patches@opensource.cirrus.com \
--cc=pzalewski@thegoodpenguin.co.uk \
--cc=qipeng.zha@intel.com \
--cc=rf@opensource.cirrus.com \
--cc=wens@kernel.org \
--cc=zhaoqunqin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®