* [PATCH] swiotlb: Remove redundant swiotlb_force
@ 2022-06-22 14:29 Steven Price
2022-06-22 14:32 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Steven Price @ 2022-06-22 14:29 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Steven Price, iommu, linux-kernel, Konrad Rzeszutek Wilk
The variable (and enum) was removed in commit c6af2aa9ffc9 ("swiotlb:
make the swiotlb_init interface more useful") but the declaration was
left in swiotlb.h. Tidy up by removing the declaration as well.
Signed-off-by: Steven Price <steven.price@arm.com>
---
include/linux/swiotlb.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
index 7ed35dd3de6e..b1f5ace37502 100644
--- a/include/linux/swiotlb.h
+++ b/include/linux/swiotlb.h
@@ -60,8 +60,6 @@ dma_addr_t swiotlb_map(struct device *dev, phys_addr_t phys,
size_t size, enum dma_data_direction dir, unsigned long attrs);
#ifdef CONFIG_SWIOTLB
-extern enum swiotlb_force swiotlb_force;
-
/**
* struct io_tlb_mem - IO TLB Memory Pool Descriptor
*
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] swiotlb: Remove redundant swiotlb_force
2022-06-22 14:29 [PATCH] swiotlb: Remove redundant swiotlb_force Steven Price
@ 2022-06-22 14:32 ` Christoph Hellwig
2022-06-22 14:33 ` Steven Price
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2022-06-22 14:32 UTC (permalink / raw)
To: Steven Price
Cc: Christoph Hellwig, iommu, linux-kernel, Konrad Rzeszutek Wilk
On Wed, Jun 22, 2022 at 03:29:52PM +0100, Steven Price wrote:
> The variable (and enum) was removed in commit c6af2aa9ffc9 ("swiotlb:
> make the swiotlb_init interface more useful") but the declaration was
> left in swiotlb.h. Tidy up by removing the declaration as well.
>
> Signed-off-by: Steven Price <steven.price@arm.com>
I just applied an identical patch from Dongli Zhang a few hours ago.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] swiotlb: Remove redundant swiotlb_force
2022-06-22 14:32 ` Christoph Hellwig
@ 2022-06-22 14:33 ` Steven Price
0 siblings, 0 replies; 3+ messages in thread
From: Steven Price @ 2022-06-22 14:33 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: iommu, linux-kernel, Konrad Rzeszutek Wilk
On 22/06/2022 15:32, Christoph Hellwig wrote:
> On Wed, Jun 22, 2022 at 03:29:52PM +0100, Steven Price wrote:
>> The variable (and enum) was removed in commit c6af2aa9ffc9 ("swiotlb:
>> make the swiotlb_init interface more useful") but the declaration was
>> left in swiotlb.h. Tidy up by removing the declaration as well.
>>
>> Signed-off-by: Steven Price <steven.price@arm.com>
>
> I just applied an identical patch from Dongli Zhang a few hours ago.
Ah, I missed that. Sorry for the noise!
Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-22 14:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-22 14:29 [PATCH] swiotlb: Remove redundant swiotlb_force Steven Price
2022-06-22 14:32 ` Christoph Hellwig
2022-06-22 14:33 ` Steven Price
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®