* [PATCH] drm/msm/dpu: Clear perf params before calculating bw
@ 2025-03-06 3:46 Jessica Zhang
2025-03-06 5:03 ` Abhinav Kumar
2025-03-06 6:48 ` Dmitry Baryshkov
0 siblings, 2 replies; 3+ messages in thread
From: Jessica Zhang @ 2025-03-06 3:46 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Sean Paul, Marijn Suijten,
David Airlie, Simona Vetter
Cc: Abhinav Kumar, linux-arm-msm, dri-devel, freedreno, linux-kernel,
Jessica Zhang
To prevent incorrect BW calculation, zero out dpu_core_perf_params
before it is passed into dpu_core_perf_aggregate().
Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
index 7ff3405c68675..0fb5789c60d0d 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
@@ -164,7 +164,7 @@ int dpu_core_perf_crtc_check(struct drm_crtc *crtc,
u32 bw, threshold;
struct dpu_crtc_state *dpu_cstate;
struct dpu_kms *kms;
- struct dpu_core_perf_params perf;
+ struct dpu_core_perf_params perf = { 0 };
if (!crtc || !state) {
DPU_ERROR("invalid crtc\n");
---
base-commit: 6d3175a72cc07e90f81fb35841048a8a9b5134cb
change-id: 20250305-perf-calc-fix-07147a3ff410
Best regards,
--
Jessica Zhang <quic_jesszhan@quicinc.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm/dpu: Clear perf params before calculating bw
2025-03-06 3:46 [PATCH] drm/msm/dpu: Clear perf params before calculating bw Jessica Zhang
@ 2025-03-06 5:03 ` Abhinav Kumar
2025-03-06 6:48 ` Dmitry Baryshkov
1 sibling, 0 replies; 3+ messages in thread
From: Abhinav Kumar @ 2025-03-06 5:03 UTC (permalink / raw)
To: Jessica Zhang, Rob Clark, Dmitry Baryshkov, Sean Paul,
Marijn Suijten, David Airlie, Simona Vetter
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel
On 3/5/2025 7:46 PM, Jessica Zhang wrote:
> To prevent incorrect BW calculation, zero out dpu_core_perf_params
> before it is passed into dpu_core_perf_aggregate().
>
> Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Fixes: 795aef6f3653 ("drm/msm/dpu: remove duplicate code calculating sum
of bandwidths")
Good catch!
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
> index 7ff3405c68675..0fb5789c60d0d 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
> @@ -164,7 +164,7 @@ int dpu_core_perf_crtc_check(struct drm_crtc *crtc,
> u32 bw, threshold;
> struct dpu_crtc_state *dpu_cstate;
> struct dpu_kms *kms;
> - struct dpu_core_perf_params perf;
> + struct dpu_core_perf_params perf = { 0 };
>
> if (!crtc || !state) {
> DPU_ERROR("invalid crtc\n");
>
> ---
> base-commit: 6d3175a72cc07e90f81fb35841048a8a9b5134cb
> change-id: 20250305-perf-calc-fix-07147a3ff410
>
> Best regards,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm/dpu: Clear perf params before calculating bw
2025-03-06 3:46 [PATCH] drm/msm/dpu: Clear perf params before calculating bw Jessica Zhang
2025-03-06 5:03 ` Abhinav Kumar
@ 2025-03-06 6:48 ` Dmitry Baryshkov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2025-03-06 6:48 UTC (permalink / raw)
To: Jessica Zhang
Cc: Rob Clark, Sean Paul, Marijn Suijten, David Airlie,
Simona Vetter, Abhinav Kumar, linux-arm-msm, dri-devel,
freedreno, linux-kernel
On Wed, Mar 05, 2025 at 07:46:44PM -0800, Jessica Zhang wrote:
> To prevent incorrect BW calculation, zero out dpu_core_perf_params
> before it is passed into dpu_core_perf_aggregate().
>
> Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-06 6:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-06 3:46 [PATCH] drm/msm/dpu: Clear perf params before calculating bw Jessica Zhang
2025-03-06 5:03 ` Abhinav Kumar
2025-03-06 6:48 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®