RE: [sailus-media-tree:master 15/16] drivers/media/i2c/hi847.c:2700:49: error: passing argument 2 of 'v4l2_subdev_get_try_format' from incompatible pointer type

["Tu, ShawnX" <shawnx.tu@intel.com>]

Hi Sakari,

Thanks for your information.
I'll update the driver later.

Thanks,
Shawn
-----Original Message-----
From: Sakari Ailus <sakari.ailus@linux.intel.com> 
Sent: Thursday, January 13, 2022 12:04 AM
To: lkp <lkp@intel.com>
Cc: Tu, ShawnX <shawnx.tu@intel.com>; kbuild-all@lists.01.org; linux-kernel@vger.kernel.org
Subject: Re: [sailus-media-tree:master 15/16] drivers/media/i2c/hi847.c:2700:49: error: passing argument 2 of 'v4l2_subdev_get_try_format' from incompatible pointer type

Hi Shawn,

On Wed, Jan 12, 2022 at 11:18:55PM +0800, kernel test robot wrote:
>    drivers/media/i2c/hi847.c: In function 'hi847_set_format':
> >> drivers/media/i2c/hi847.c:2700:49: error: passing argument 2 of 
> >> 'v4l2_subdev_get_try_format' from incompatible pointer type 
> >> [-Werror=incompatible-pointer-types]
>     2700 |                 *v4l2_subdev_get_try_format(sd, cfg, fmt->pad) = fmt->format;
>          |                                                 ^~~
>          |                                                 |
>          |                                                 struct v4l2_subdev_pad_config *

There's been an API change in how the sub-device try state is stored and accessed. The patch changing the other drivers is:

<URL:https://git.linuxtv.org/sailus/media_tree.git/commit/?id=0d346d2a6f54f06f36b224fd27cd6eafe8c83be9>

Could you make similar changes to the hi847 driver? I'll then squash that patch into the current patch adding the driver.

--
Kind regards,

Sakari Ailus