From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: kernel test robot <lkp@intel.com>
Cc: Shawn Tu <shawnx.tu@intel.com>,
kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: [sailus-media-tree:master 15/16] drivers/media/i2c/hi847.c:2700:49: error: passing argument 2 of 'v4l2_subdev_get_try_format' from incompatible pointer type
Date: Wed, 12 Jan 2022 18:03:34 +0200 [thread overview]
Message-ID: <Yd771idbGaGVU9OQ@paasikivi.fi.intel.com> (raw)
In-Reply-To: <202201122346.jc4ZqZm5-lkp@intel.com>
Hi Shawn,
On Wed, Jan 12, 2022 at 11:18:55PM +0800, kernel test robot wrote:
> drivers/media/i2c/hi847.c: In function 'hi847_set_format':
> >> drivers/media/i2c/hi847.c:2700:49: error: passing argument 2 of 'v4l2_subdev_get_try_format' from incompatible pointer type [-Werror=incompatible-pointer-types]
> 2700 | *v4l2_subdev_get_try_format(sd, cfg, fmt->pad) = fmt->format;
> | ^~~
> | |
> | struct v4l2_subdev_pad_config *
There's been an API change in how the sub-device try state is stored and
accessed. The patch changing the other drivers is:
<URL:https://git.linuxtv.org/sailus/media_tree.git/commit/?id=0d346d2a6f54f06f36b224fd27cd6eafe8c83be9>
Could you make similar changes to the hi847 driver? I'll then squash that
patch into the current patch adding the driver.
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2022-01-12 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 15:18 kernel test robot
2022-01-12 16:03 ` Sakari Ailus [this message]
2022-01-13 3:59 ` Tu, ShawnX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yd771idbGaGVU9OQ@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=shawnx.tu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®