mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Erikas Bitovtas" <xerikasxx@gmail.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Peter Meerwald" <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org
Subject: Re: [PATCH v5 1/8] dt-bindings: iio: light: vcnl4000: add regulators
Date: Thu, 19 Mar 2026 13:13:14 +0100	[thread overview]
Message-ID: <1e81ad50-19c9-4648-9f43-3570757e75bc@kernel.org> (raw)
In-Reply-To: <20260319-vcnl4000-regulators-v5-1-a025d3332805@gmail.com>

On 19/03/2026 12:58, Erikas Bitovtas wrote:
> These sensors can accept 2 supplies - one for the sensor and one for IR
> LED [1]. Add supply properties for the sensor - 2 for the sensors and
> one external, for their open drain interrupt line, to ensure the sensor
> is powered on before proceeding with setup.
> 
> [1] https://www.vishay.com/docs/84274/vcnl4040.pdf
> 
> Reviewed-by: David Lechner <dlechner@baylibre.com>
> Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
> ---
>  Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> index 2ba4d5de4ec4..44882a90bc76 100644
> --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> @@ -33,6 +33,10 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  vdd-supply: true
> +  vio-supply: true

That's still a property of I2C bus controller, but if you disagree then
I expect following Rob's comment.
https://lore.kernel.org/all/20230321220825.GA1685482-robh@kernel.org/

Best regards,
Krzysztof

  reply	other threads:[~2026-03-19 12:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19 11:58 [PATCH v5 0/8] iio: light: vcnl4000: add regulator support Erikas Bitovtas
2026-03-19 11:58 ` [PATCH v5 1/8] dt-bindings: iio: light: vcnl4000: add regulators Erikas Bitovtas
2026-03-19 12:13   ` Krzysztof Kozlowski [this message]
2026-03-19 13:22   ` Rob Herring (Arm)
2026-03-19 11:58 ` [PATCH v5 2/8] iio: light: vcnl4000: sort includes by their name Erikas Bitovtas
2026-03-19 11:58 ` [PATCH v5 3/8] iio: light: vcnl4000: move power enablement from init to probe Erikas Bitovtas
2026-03-19 11:58 ` [PATCH v5 4/8] iio: light: vcnl4000: replace mutex_init with devm_mutex_init Erikas Bitovtas
2026-03-19 11:58 ` [PATCH v5 5/8] iio: light: vcnl4000: remove error messages for trigger and irq Erikas Bitovtas
2026-03-19 11:58 ` [PATCH v5 6/8] iio: light: vcnl4000: use variables for I2C client and device instances Erikas Bitovtas
2026-03-19 11:58 ` [PATCH v5 7/8] iio: light: vcnl4000: remove redundant check for proximity-near-level Erikas Bitovtas
2026-03-19 11:58 ` [PATCH v5 8/8] iio: light: vcnl4000: add support for regulators Erikas Bitovtas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e81ad50-19c9-4648-9f43-3570757e75bc@kernel.org \
    --to=krzk@kernel.org \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=phone-devel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=robh@kernel.org \
    --cc=xerikasxx@gmail.com \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®