* Re: [PATCH v4 3/4] drm/mediatek: Fix unintentional integer overflow in multiplying different types
[not found] ` <20230714094908.13087-4-jason-jh.lin@mediatek.com>
@ 2023-07-17 7:47 ` AngeloGioacchino Del Regno
2023-08-31 8:06 ` Fei Shao
1 sibling, 0 replies; 2+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-07-17 7:47 UTC (permalink / raw)
To: Jason-JH.Lin, Chun-Kuang Hu, Alexandre Mergnat
Cc: Matthias Brugger, Jason-ch Chen, Johnson Wang, Singo Chang,
Nancy Lin, Shawn Sung, dri-devel, linux-mediatek,
linux-arm-kernel, linux-kernel,
Project_Global_Chrome_Upstream_Group
Il 14/07/23 11:49, Jason-JH.Lin ha scritto:
> 1. Instead of multiplying 2 variable of different types. Change to
> assign a value of one variable and then multiply the other variable.
>
> 2. Add a int variable for multiplier calculation instead of calculating
> different types multiplier with dma_addr_t variable directly.
>
> Fixes: 1a64a7aff8da ("drm/mediatek: Fix cursor plane no update")
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v4 3/4] drm/mediatek: Fix unintentional integer overflow in multiplying different types
[not found] ` <20230714094908.13087-4-jason-jh.lin@mediatek.com>
2023-07-17 7:47 ` [PATCH v4 3/4] drm/mediatek: Fix unintentional integer overflow in multiplying different types AngeloGioacchino Del Regno
@ 2023-08-31 8:06 ` Fei Shao
1 sibling, 0 replies; 2+ messages in thread
From: Fei Shao @ 2023-08-31 8:06 UTC (permalink / raw)
To: Jason-JH.Lin, Chun-Kuang Hu
Cc: AngeloGioacchino Del Regno, Alexandre Mergnat, Matthias Brugger,
Jason-ch Chen, Johnson Wang, Singo Chang, Nancy Lin, Shawn Sung,
dri-devel, linux-mediatek, linux-arm-kernel, linux-kernel,
Project_Global_Chrome_Upstream_Group
On Fri, Jul 14, 2023 at 6:59 PM Jason-JH.Lin <jason-jh.lin@mediatek.com> wrote:
>
> 1. Instead of multiplying 2 variable of different types. Change to
> assign a value of one variable and then multiply the other variable.
>
> 2. Add a int variable for multiplier calculation instead of calculating
> different types multiplier with dma_addr_t variable directly.
>
> Fixes: 1a64a7aff8da ("drm/mediatek: Fix cursor plane no update")
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
Hi CK,
It seems like the series was accepted but this patch in particular
didn't make it into the tree. Could you take a look?
Regards,
Fei
^ permalink raw reply [flat|nested] 2+ messages in thread