From: Eduard Zingerman <eddyz87@gmail.com>
To: "Nico Pache (Red Hat)" <nico.pache@linux.dev>,
"Ricardo B. Marlière (SUSE)" <ricardo@marliere.net>,
ihor.solodrai@linux.dev, nickolay.lysenko@gmail.com
Cc: bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
Emil Tsalapatis <emil@etsalapatis.com>,
Jiri Olsa <jolsa@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
Song Liu <song@kernel.org>, Andrii Nakryiko <andrii@kernel.org>,
Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@linux.dev>
Subject: Re: [PATCH 0/3] selftests/bpf: Fixes for out-of-tree builds
Date: Thu, 24 Sep 2026 00:11:02 -0700 [thread overview]
Message-ID: <1eb267761bd627b63e5c78bdf76215c019aa3fa0.camel@gmail.com> (raw)
In-Reply-To: <e4761ef3-4385-4ec2-ada8-70f293c14331@linux.dev>
On Wed, 2026-09-23 at 14:06 -0600, Nico Pache (Red Hat) wrote:
>
> On 9/21/26 3:42 PM, Eduard Zingerman wrote:
> > On Mon, 2026-09-21 at 15:15 -0600, Nico Pache (Red Hat) wrote:
> > >
> > > On 9/21/26 3:04 PM, Eduard Zingerman wrote:
> > > > On Mon, 2026-09-21 at 14:40 -0600, Nico Pache (Red Hat) wrote:
> > > >
> > > > ...
> > > >
> > > > > Given your series was defferred, and there is a "rewrite" coming, what would
> > > > > be the best approach to working together (between us three) to get these
> > > > > fixes in that series too.
> > > >
> > > > The, "rewrite", as you call it, had landed today.
> > >
> > > oh thats great news. I checked on Friday and didnt see it. Thanks for the update :)
> > >
> > > > So the series in question can be re-spun.
> > > > Regarding your patch on top of it, it appears you can just post is separately.
> > > > However, I am inclined to be confrontational towards changes like this one.
> > > > The purpose of the selftests makefile is to run selftests as appropriate
> > > > for current tip of the kernel tree using a very specific kernel configuration.
> > > > Main users of this makefile are BPF developers and BPF CI.
> > >
> > > Yeah we are trying to reincorporate BPF as part of our CI. It has bit rotted in
> > > the Fedora env, and our large amount of build variant is where things are
> > > starting to go wrong. We need to build selftests for multiple variants, and be
> > > able to specify which variant we are building for. Hence the out-of-tree build
> > > with specific vmlinux.
> >
> > Why can't you build the kernel and the selftests in the same out of tree location?
> > The change you are proposing is contained, but it's a death by thousand cuts,
> > the selftests makefile is quite a Frankenstein's monster already.
>
> Due to incremental builds, and tool building in different env's
Can you copy vmlinux to the output directory?
> >
> > > Is there any other approach you'd suggest? I personally dont work on BPF, but am
> > > trying to cleanup/fix our selftests builds for Upstream/Fedora CI.
> >
> > How many Fedora-specific kernel patches do you carry already?
>
> So far its just the series Im replying to here, and the commit I appended.
Okay, I was under impression that distros bear a ton of custom patches
and that adding another one adjusting random makefiles won't make a
difference.
If that is not the case, then I'm being unreasonable and the change is small.
next prev parent reply other threads:[~2026-09-24 7:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 0:06 Ricardo B. Marlière (SUSE)
2026-07-29 0:06 ` [PATCH 1/3] selftests/bpf: Route generated test headers to OUTPUT Ricardo B. Marlière (SUSE)
2026-08-06 20:32 ` Ihor Solodrai
2026-07-29 0:06 ` [PATCH 2/3] selftests/bpf: Route libarena build artifacts " Ricardo B. Marlière (SUSE)
2026-08-06 20:33 ` Ihor Solodrai
2026-07-29 0:06 ` [PATCH 3/3] selftests/bpf: Route test_kmods " Ricardo B. Marlière (SUSE)
2026-08-06 20:35 ` Ihor Solodrai
2026-08-06 20:29 ` [PATCH 0/3] selftests/bpf: Fixes for out-of-tree builds Ihor Solodrai
2026-08-06 20:47 ` Ricardo B. Marlière
2026-09-21 20:40 ` Nico Pache (Red Hat)
2026-09-21 21:04 ` Eduard Zingerman
2026-09-21 21:15 ` Nico Pache (Red Hat)
2026-09-21 21:42 ` Eduard Zingerman
2026-09-23 20:06 ` Nico Pache (Red Hat)
2026-09-24 7:11 ` Eduard Zingerman [this message]
2026-09-21 21:42 ` Alexei Starovoitov
2026-09-22 18:31 ` Ricardo B. Marlière (SUSE)
2026-09-24 7:06 ` Eduard Zingerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1eb267761bd627b63e5c78bdf76215c019aa3fa0.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=emil@etsalapatis.com \
--cc=ihor.solodrai@linux.dev \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=nickolay.lysenko@gmail.com \
--cc=nico.pache@linux.dev \
--cc=ricardo@marliere.net \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®