mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eduard Zingerman <eddyz87@gmail.com>
To: "Ricardo B. Marlière (SUSE)" <ricardo@marliere.net>,
	"Nico Pache (Red Hat)" <nico.pache@linux.dev>,
	ihor.solodrai@linux.dev, nickolay.lysenko@gmail.com
Cc: bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
	Emil Tsalapatis <emil@etsalapatis.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Yonghong Song <yonghong.song@linux.dev>,
	Song Liu <song@kernel.org>, Andrii Nakryiko <andrii@kernel.org>,
	Shuah Khan <shuah@kernel.org>,
	 linux-kernel@vger.kernel.org,
	Kumar Kartikeya Dwivedi <memxor@gmail.com>,
	 Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Martin KaFai Lau <martin.lau@linux.dev>
Subject: Re: [PATCH 0/3] selftests/bpf: Fixes for out-of-tree builds
Date: Thu, 24 Sep 2026 00:06:52 -0700	[thread overview]
Message-ID: <78e6ad2dc979983bd65514166fa0020729a4147d.camel@gmail.com> (raw)
In-Reply-To: <DLM25PIKJTE5.1Q1IO5PAM6VBD@marliere.net>

On Tue, 2026-09-22 at 15:31 -0300, Ricardo B. Marlière (SUSE) wrote:
> On Mon Sep 21, 2026 at 6:04 PM -03, Eduard Zingerman wrote:
> > On Mon, 2026-09-21 at 14:40 -0600, Nico Pache (Red Hat) wrote:
> > 
> > ...
> > 
> > > Given your series was defferred, and there is a "rewrite" coming, what would
> > > be the best approach to working together (between us three) to get these
> > > fixes in that series too. 
> > 
> > The, "rewrite", as you call it, had landed today.
> > So the series in question can be re-spun.
> > Regarding your patch on top of it, it appears you can just post is separately.
> > However, I am inclined to be confrontational towards changes like this one.
> > The purpose of the selftests makefile is to run selftests as appropriate
> > for current tip of the kernel tree using a very specific kernel configuration.
> 
> Ideally, if a Kconfig symbol is needed and the kernel under test does not
> have it, tests are skipped. But with BPF they were simply not built,
> rendering the tests useless for anything other than in-tree vmlinux with
> tools/selftests/bpf/config*.
> 
> > Main users of this makefile are BPF developers and BPF CI.
> 
> But they shouldn't be the *only* ones, IMHO. Enabling distros to build and
> run the tests is also valuable to catch regressions in their kernels, don't
> you think?
> 
> > Support for distros customizing the makefile is a non-goal.
> > The "PERMISSIVE" change done enough damage already.
> 
> It's ugly, I agree, but what damage has it caused? I see that it's going to
> be reverted anyway, but I would appreciate if you could elaborate.

It's the first time I see a makefile that builds stuff not fully but
90% of it and returns success. The damage is the need to maintain it
going forward that already cost some time.

Do you have a list of kernel configs you had issues with?

      reply	other threads:[~2026-09-24  7:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29  0:06 Ricardo B. Marlière (SUSE)
2026-07-29  0:06 ` [PATCH 1/3] selftests/bpf: Route generated test headers to OUTPUT Ricardo B. Marlière (SUSE)
2026-08-06 20:32   ` Ihor Solodrai
2026-07-29  0:06 ` [PATCH 2/3] selftests/bpf: Route libarena build artifacts " Ricardo B. Marlière (SUSE)
2026-08-06 20:33   ` Ihor Solodrai
2026-07-29  0:06 ` [PATCH 3/3] selftests/bpf: Route test_kmods " Ricardo B. Marlière (SUSE)
2026-08-06 20:35   ` Ihor Solodrai
2026-08-06 20:29 ` [PATCH 0/3] selftests/bpf: Fixes for out-of-tree builds Ihor Solodrai
2026-08-06 20:47   ` Ricardo B. Marlière
2026-09-21 20:40 ` Nico Pache (Red Hat)
2026-09-21 21:04   ` Eduard Zingerman
2026-09-21 21:15     ` Nico Pache (Red Hat)
2026-09-21 21:42       ` Eduard Zingerman
2026-09-23 20:06         ` Nico Pache (Red Hat)
2026-09-24  7:11           ` Eduard Zingerman
2026-09-21 21:42     ` Alexei Starovoitov
2026-09-22 18:31     ` Ricardo B. Marlière (SUSE)
2026-09-24  7:06       ` Eduard Zingerman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78e6ad2dc979983bd65514166fa0020729a4147d.camel@gmail.com \
    --to=eddyz87@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=emil@etsalapatis.com \
    --cc=ihor.solodrai@linux.dev \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=memxor@gmail.com \
    --cc=nickolay.lysenko@gmail.com \
    --cc=nico.pache@linux.dev \
    --cc=ricardo@marliere.net \
    --cc=shuah@kernel.org \
    --cc=song@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®