* [PATCH] staging: rtl8723bs: Fix a resource leak in sd_int_dpc
@ 2021-06-28 15:22 Xiangyang Zhang
2021-06-28 15:35 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Xiangyang Zhang @ 2021-06-28 15:22 UTC (permalink / raw)
To: gregkh
Cc: hdegoede, Larry.Finger, fabioaiuto83, linux-staging,
linux-kernel, xyz.sun.ok
The "c2h_evt" variable is not freed when function call
"c2h_evt_read_88xx" failed
Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver")
Signed-off-by: Xiangyang Zhang <xyz.sun.ok@gmail.com>
---
drivers/staging/rtl8723bs/hal/sdio_ops.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
index 2dd251ce177e..a545832a468e 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
@@ -909,6 +909,8 @@ void sd_int_dpc(struct adapter *adapter)
} else {
rtw_c2h_wk_cmd(adapter, (u8 *)c2h_evt);
}
+ } else {
+ kfree(c2h_evt);
}
} else {
/* Error handling for malloc fail */
--
2.19.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8723bs: Fix a resource leak in sd_int_dpc
2021-06-28 15:22 [PATCH] staging: rtl8723bs: Fix a resource leak in sd_int_dpc Xiangyang Zhang
@ 2021-06-28 15:35 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2021-06-28 15:35 UTC (permalink / raw)
To: Xiangyang Zhang, gregkh
Cc: Larry.Finger, fabioaiuto83, linux-staging, linux-kernel
Hi,
On 6/28/21 5:22 PM, Xiangyang Zhang wrote:
> The "c2h_evt" variable is not freed when function call
> "c2h_evt_read_88xx" failed
>
> Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver")
> Signed-off-by: Xiangyang Zhang <xyz.sun.ok@gmail.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/staging/rtl8723bs/hal/sdio_ops.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
> index 2dd251ce177e..a545832a468e 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
> +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
> @@ -909,6 +909,8 @@ void sd_int_dpc(struct adapter *adapter)
> } else {
> rtw_c2h_wk_cmd(adapter, (u8 *)c2h_evt);
> }
> + } else {
> + kfree(c2h_evt);
> }
> } else {
> /* Error handling for malloc fail */
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-28 15:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-28 15:22 [PATCH] staging: rtl8723bs: Fix a resource leak in sd_int_dpc Xiangyang Zhang
2021-06-28 15:35 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®