From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jon Lin <jon.lin@rock-chips.com>, broonie@kernel.org
Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
heiko@sntech.de, linux-arm-kernel@lists.infradead.org,
linux-spi@vger.kernel.org
Subject: Re: [PATCH 2/2] spi: rockchip-sfc: Add rockchip,fspi compatible
Date: Wed, 8 Jan 2025 08:03:28 +0100 [thread overview]
Message-ID: <1ef2ece5-f4ed-46ca-9bf5-75f898565a62@kernel.org> (raw)
In-Reply-To: <20250107154755.2037197-2-jon.lin@rock-chips.com>
On 07/01/2025 16:47, Jon Lin wrote:
>
> diff --git a/drivers/spi/spi-rockchip-sfc.c b/drivers/spi/spi-rockchip-sfc.c
> index 59de351499a0..88fbde27925e 100644
> --- a/drivers/spi/spi-rockchip-sfc.c
> +++ b/drivers/spi/spi-rockchip-sfc.c
> @@ -808,6 +808,7 @@ static const struct dev_pm_ops rockchip_sfc_pm_ops = {
> };
>
> static const struct of_device_id rockchip_sfc_dt_ids[] = {
> + { .compatible = "rockchip,fspi"},
> { .compatible = "rockchip,sfc"},
I don't understand why you are adding generic compatible which is not
even used. Use proper SoC specific compatibles and fallbacks when
applicable (see writing bindings document).
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-08 7:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 15:47 [PATCH 1/2] dt-bindings: " Jon Lin
2025-01-07 15:47 ` [PATCH 2/2] " Jon Lin
2025-01-08 7:03 ` Krzysztof Kozlowski [this message]
2025-01-09 8:29 ` Jon Lin
2025-01-08 7:02 ` [PATCH 1/2] dt-bindings: " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ef2ece5-f4ed-46ca-9bf5-75f898565a62@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=jon.lin@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®