[PATCH 1/2] dt-bindings: spi: rockchip-sfc: Add rockchip,fspi compatible

[PATCH 1/2] dt-bindings: spi: rockchip-sfc: Add rockchip,fspi compatible

[Jon Lin]

FSPI is an SFC upgrade IP that adds functions such as XIP.

Signed-off-by: Jon Lin <jon.lin@rock-chips.com>
---

 Documentation/devicetree/bindings/spi/rockchip-sfc.yaml | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml b/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml
index ac1503de0478..4d64155d03f8 100644
--- a/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml
+++ b/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml
@@ -15,11 +15,15 @@ allOf:
 
 properties:
   compatible:
-    const: rockchip,sfc
+    enum:
+      - rockchip,fspi
+      - rockchip,sfc
+
     description:
       The rockchip sfc controller is a standalone IP with version register,
       and the driver can handle all the feature difference inside the IP
       depending on the version register.
+      The rockchip flexible spi controller is the next generation IP of sfc.
 
   reg:
     maxItems: 1
-- 
2.34.1

[PATCH 2/2] spi: rockchip-sfc: Add rockchip,fspi compatible

[Jon Lin]

FSPI is an SFC upgrade IP, support new feature like XIP. But RK AP
SOC FSPI early version integration implementation is the same as SFC.

Add rockchip,fspi compatible to match with RK technical reference
manual.

Signed-off-by: Jon Lin <jon.lin@rock-chips.com>
---

 drivers/spi/spi-rockchip-sfc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spi-rockchip-sfc.c b/drivers/spi/spi-rockchip-sfc.c
index 59de351499a0..88fbde27925e 100644
--- a/drivers/spi/spi-rockchip-sfc.c
+++ b/drivers/spi/spi-rockchip-sfc.c
@@ -808,6 +808,7 @@ static const struct dev_pm_ops rockchip_sfc_pm_ops = {
 };
 
 static const struct of_device_id rockchip_sfc_dt_ids[] = {
+	{ .compatible = "rockchip,fspi"},
 	{ .compatible = "rockchip,sfc"},
 	{ /* sentinel */ }
 };
-- 
2.34.1

Re: [PATCH 1/2] dt-bindings: spi: rockchip-sfc: Add rockchip,fspi compatible

[Krzysztof Kozlowski]

On 07/01/2025 16:47, Jon Lin wrote:
> FSPI is an SFC upgrade IP that adds functions such as XIP.
> 
> Signed-off-by: Jon Lin <jon.lin@rock-chips.com>
> ---

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.
</form letter>

> 
>  Documentation/devicetree/bindings/spi/rockchip-sfc.yaml | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml b/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml
> index ac1503de0478..4d64155d03f8 100644
> --- a/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml
> +++ b/Documentation/devicetree/bindings/spi/rockchip-sfc.yaml
> @@ -15,11 +15,15 @@ allOf:
>  
>  properties:
>    compatible:
> -    const: rockchip,sfc
> +    enum:
> +      - rockchip,fspi

Don't grow generic patterns like that. Only SoC specific compatibles.

> +      - rockchip,sfc


Best regards,
Krzysztof

Re: [PATCH 2/2] spi: rockchip-sfc: Add rockchip,fspi compatible

[Krzysztof Kozlowski]

On 07/01/2025 16:47, Jon Lin wrote:
> 
> diff --git a/drivers/spi/spi-rockchip-sfc.c b/drivers/spi/spi-rockchip-sfc.c
> index 59de351499a0..88fbde27925e 100644
> --- a/drivers/spi/spi-rockchip-sfc.c
> +++ b/drivers/spi/spi-rockchip-sfc.c
> @@ -808,6 +808,7 @@ static const struct dev_pm_ops rockchip_sfc_pm_ops = {
>  };
>  
>  static const struct of_device_id rockchip_sfc_dt_ids[] = {
> +	{ .compatible = "rockchip,fspi"},
>  	{ .compatible = "rockchip,sfc"},
I don't understand why you are adding generic compatible which is not
even used. Use proper SoC specific compatibles and fallbacks when
applicable (see writing bindings document).

Best regards,
Krzysztof

Re: [PATCH 2/2] spi: rockchip-sfc: Add rockchip,fspi compatible

[Jon Lin]

On 2025/1/8 15:03, Krzysztof Kozlowski wrote:
> On 07/01/2025 16:47, Jon Lin wrote:
>>
>> diff --git a/drivers/spi/spi-rockchip-sfc.c b/drivers/spi/spi-rockchip-sfc.c
>> index 59de351499a0..88fbde27925e 100644
>> --- a/drivers/spi/spi-rockchip-sfc.c
>> +++ b/drivers/spi/spi-rockchip-sfc.c
>> @@ -808,6 +808,7 @@ static const struct dev_pm_ops rockchip_sfc_pm_ops = {
>>   };
>>   
>>   static const struct of_device_id rockchip_sfc_dt_ids[] = {
>> +	{ .compatible = "rockchip,fspi"},
>>   	{ .compatible = "rockchip,sfc"},
> I don't understand why you are adding generic compatible which is not
> even used. Use proper SoC specific compatibles and fallbacks when
> applicable (see writing bindings document).
> 

Thanks for the reminder. These two submissions are indeed redundant 
submissions at present and are not recommended to be merged.

It is indeed necessary to add submissions like rockchip,rkxxxxx-fspi 
when there are specific SOC requirements, and attach the associated priv 
data.

The merging of this submission is suspended.

> Best regards,
> Krzysztof
> 
>