Re: [PATCH 2/2] arm64: dts: qcom: Add support for Pixel 3 and Pixel 3 XL

[David Heidelberg <david@ixit.cz>]

On 19/10/2025 13:51, Dmitry Baryshkov wrote:
> On Fri, Oct 17, 2025 at 06:59:14PM +0200, David Heidelberg wrote:
>> On 06/10/2025 00:03, Dmitry Baryshkov wrote:
>>> On Sun, Oct 05, 2025 at 03:16:29PM +0200, David Heidelberg via B4 Relay wrote:
>>>> From: David Heidelberg <david@ixit.cz>
>>>>
>>>> This adds initial device tree support for the following phones:
>>>>
>>>>    - Google Pixel 3 (blueline)
>>>>    - Google Pixel 3 XL (crosshatch)
>>>
>>> Great to finally see it being submitted!
>>>
>>>>
>>>> Both phone boards use the same identifiers and differ only slightly
>>>> in their connected peripherals.
>>>>
>>>> Supported functionality includes:
>>>>    - Debug UART
>>>>    - UFS
>>>>    - Charger
>>>>    - USB-C (peripheral mode)
>>>>    - Display (Pixel 3 only)
>>>
>>> No remoteprocs / IPA / GPU / Venus / WiFi / BT? The firmware is
>>> accessible to download from Google and it can be further repackaged (but
>>> not redistributed). See [1], [2].
>>>
>>> The phones share all firmware except for the bdwlan, so hopefully you
>>> can add 'Google/blueline/foo.mbn' to the common file.
>>
>> Would it be acceptable to use path format qcom/sdm845/$codename/ e.g.
>> qcom/sdm845/blueline as it's used elsewhere?
> 
> We have settled on qcom/SoC/Vendor/device/ long ago. Could you please
> follow? All upstream Qualcomm devices follow this approach.

Sure, in next version it's done! Would you be open if I sent changes to 
the existing firmware paths for sdm845 firmwares?

Thank you

> 
> bdwlan should be sent to ath10k ML:
> https://wireless.docs.kernel.org/en/latest/en/users/drivers/ath10k/boardfiles.html
> 
>> As I'm looking at the Google scripts, I assume both blueline/crosshatch use
>> same firmware (which makes sense, as only the battery and display is
>> different).
>>
>> David
>>
> 

-- 
David Heidelberg