From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Dan Murphy <dmurphy@ti.com>, robh+dt@kernel.org, pavel@ucw.cz
Cc: linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH 0/5] TI LMU rework
Date: Wed, 3 Apr 2019 22:14:28 +0200 [thread overview]
Message-ID: <1f24fe22-7265-df4b-872a-cfb3622002c9@gmail.com> (raw)
In-Reply-To: <1037091e-1f4a-3922-16ee-282253dad7e0@ti.com>
Hi Dan,
On 4/3/19 2:02 PM, Dan Murphy wrote:
> Hello
>
> On 3/25/19 9:23 AM, Dan Murphy wrote:
>> All
>>
>> I know that it has been a long time but I put some additional effort into this
>> code. The TI LMU common code right now handles brightness and ramp up/down
>> setting for the LM3697. This so far are the common features I could find.
>>
>> The LM3697 driver has the ability to assign HVLED strings to specific control
>> banks as well as assigning different max brightnesses to these strings.
>>
>> Fault monitoring was removed as the data sheet indicates that this is for
>> production tests only.
>>
>> I have plans to add additional LED drivers to use the TI LMU but I figured trying
>> to add all of them at once would be a daunting review and probably wrought with
>> problems.
>>
>
> I have a new device I need to add to the TI LMU code LM36274.
> This will use the MFD ti-lmu code and I will need to create the backlight and regulator drivers.
>
> I need to know how to proceed. I can base the work off of the LM3532 patchset or use what is in mainline
> or base it off this patchset. The LM36274 would use the ti-lmu-led-common code for brightness setting but the
> ramping times are different.
>
> Please let me know how to proceed.
The patch set looks good to me with a single reservation I've just
posted. You can base your work off it.
--
Best regards,
Jacek Anaszewski
prev parent reply other threads:[~2019-04-03 20:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 14:23 Dan Murphy
2019-03-25 14:23 ` [PATCH 1/5] dt-bindings: mfd: Update the ramp up/down property Dan Murphy
2019-04-04 8:19 ` Lee Jones
2019-04-04 12:07 ` Dan Murphy
2019-03-25 14:24 ` [PATCH 2/5] leds: TI LMU: Add common code for TI LMU devices Dan Murphy
2019-04-04 13:22 ` Pavel Machek
2019-03-25 14:24 ` [PATCH 3/5] dt-bindings: ti-lmu: Modify dt bindings for the LM3697 Dan Murphy
2019-04-03 20:10 ` Jacek Anaszewski
2019-04-03 20:23 ` Dan Murphy
2019-04-04 18:39 ` Jacek Anaszewski
2019-04-04 19:27 ` Dan Murphy
2019-04-04 19:31 ` Jacek Anaszewski
2019-04-04 19:34 ` Dan Murphy
2019-03-25 14:24 ` [PATCH 4/5] mfd: ti-lmu: Remove support for LM3697 Dan Murphy
2019-04-04 8:17 ` Lee Jones
2019-04-04 8:18 ` Lee Jones
2019-04-04 12:09 ` Dan Murphy
2019-03-25 14:24 ` [PATCH 5/5] leds: lm3697: Introduce the lm3697 driver Dan Murphy
2019-04-13 20:06 ` Pavel Machek
2019-04-15 12:49 ` Dan Murphy
2019-04-15 14:03 ` Pavel Machek
2019-04-15 19:53 ` Dan Murphy
2019-04-03 12:02 ` [PATCH 0/5] TI LMU rework Dan Murphy
2019-04-03 20:14 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f24fe22-7265-df4b-872a-cfb3622002c9@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=dmurphy@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®