Re: [PATCH v3 2/2] drm/tiny: add support for PIXPAPER 4.26 monochrome e-ink panel

["Thakkar, Devarsh" <devarsht@ti.com>]

Hi Thomas, LiangCheng, Javier,

On 9/17/2026 5:45 PM, Javier Martinez Canillas wrote:
> Hello Thomas,
> 
> On Thu, Sep 17, 2026 at 1:34 PM Thomas Zimmermann <tzimmermann@suse.de> wrote:
>>
>> Hi
>>
>> Am 17.09.26 um 12:49 schrieb Javier Martinez Canillas:
> 
> [...]
> 
>>> There are a few bits that I think are similar though and could be
>>> reused, for example the pixpaper_spi_write() helper logic is basically
>>> the same than ssd130x_spi_write() AFAICT.
>>>
>>> Same for pixpaper_send_cmd() and pixpaper_send_data(), I believe that
>>> is the same logic that we now have in ssd130x_write_cmds(). Specially
>>> after the recent commit 3e391b0b516b ("drm/ssd130x: Add SSD135X_FAMILY
>>> and SSD1351 support") that introduced a cmd_params_are_data flag that
>>> allows to send the operation as command and the parameters as data.
>>>
>>> So the MCU interface seems to be the same, in particular for the
>>> 4-wire SPI interface which AFAIU is what this new SSD1677 driver
>>> supports.
>>
>> I cannot advice anything here, but at least I'd like to get ssd16xx out
>> of tiny/. It would be great to have it all under solomon/. It looks like
>> sitronix/ does a similar thing.
>>
> 
> Yes, I agree. Especially since there is even some (albeit small) code
> that could be reused.

Apologies for the delay. As to what I had looked on ssd130x family it was a
different then the ssd16xx family which caters to e-paper, so I preferred to
keep it separate and write only a generic ssd16xx driver.

Yes, I plan to post ssd16xx support under solomon as suggested and that would
handle both the pixpaper and good displays, LiangCheng had confirmed that
pixpaper was functional with my staging series [0] albeit with few fixes [1]. I
am reviewing those and will try to cherry pick them and include as part of my V2

I target to post v2 by end of next week, after running thorough tests on the
epapers I have.

Kindly let me know if we are aligned on this.

[0]: https://github.com/devarsht/linux-next/commits/ssd16xx_7_2/
[1]:
https://lore.kernel.org/all/20260731-ssd16xx-pixpaper-rpi5-v1-0-18ffc0dbf59a@gmail.com/

Regards
Devarsh

>