From: Sudeep Holla <sudeep.holla@arm.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH v2] tools: perf: fix linker error when libelf config is disabled
Date: Wed, 4 Jan 2017 16:18:10 +0000 [thread overview]
Message-ID: <1f976b40-608e-412c-910c-6b0e078a8ae0@arm.com> (raw)
In-Reply-To: <a3c0a2f9-9948-6ed5-f253-0673dd0e8358@arm.com>
On 04/01/17 16:08, Sudeep Holla wrote:
>
>
> On 04/01/17 16:06, Jiri Olsa wrote:
>> On Wed, Jan 04, 2017 at 03:56:03PM +0000, Sudeep Holla wrote:
>>> When libelf is disabled in the configuration, we get the following
>>> linker error:
>>> LINK libperf-jvmti.so
>>> ld: cannot find -lelf
>>> Makefile.perf:515: recipe for target 'libperf-jvmti.so' failed
>>>
>>> Jiri pointed out that both librt and libelf are not really required. So
>>> this patch fixes the linker error by getting rid of unwanted libraries
>>> in the linker stage.
>>>
>>> Fixes: d4dfdf00d43e ("perf jvmti: Plug compilation into perf build")
>>
>> hum, AFAICS it linked -lelf and -lrt even before right? ;-)
>>
>
> Yes, sorry I forgot to remove that and trace it back the actual commit.
>
Having looked at it again, it looks new additions in the above commit.
It may be a copied from somewhere else but I can't trace it back :(.
I need your help if you want to get rid of that ;)
--
Regards,
Sudeep
next prev parent reply other threads:[~2017-01-04 16:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 13:52 [PATCH] " Sudeep Holla
2017-01-04 14:45 ` Jiri Olsa
2017-01-04 15:45 ` Sudeep Holla
2017-01-04 15:56 ` [PATCH v2] " Sudeep Holla
2017-01-04 16:06 ` Jiri Olsa
2017-01-04 16:08 ` Sudeep Holla
2017-01-04 16:18 ` Sudeep Holla [this message]
2017-01-04 17:19 ` Jiri Olsa
2017-01-04 17:26 ` Sudeep Holla
2017-01-04 17:30 ` [PATCH v3] " Sudeep Holla
2017-01-04 17:35 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f976b40-608e-412c-910c-6b0e078a8ae0@arm.com \
--to=sudeep.holla@arm.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®