From: Sudeep Holla <sudeep.holla@arm.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH] tools: perf: fix linker error when libelf config is disabled
Date: Wed, 4 Jan 2017 15:45:13 +0000 [thread overview]
Message-ID: <5aa63b9b-1479-8dc9-d505-56a73e7fd9ee@arm.com> (raw)
In-Reply-To: <20170104144537.GB4908@krava>
On 04/01/17 14:45, Jiri Olsa wrote:
> On Wed, Jan 04, 2017 at 01:52:40PM +0000, Sudeep Holla wrote:
>> When libelf is disabled in the configuration, we get the following
>> linker error:
>> LINK libperf-jvmti.so
>> ld: cannot find -lelf
>> Makefile.perf:515: recipe for target 'libperf-jvmti.so' failed
>>
>> This patch fixes the error by using the configuration macro EXTLIBS.
>>
>> Fixes: d4dfdf00d43e ("perf jvmti: Plug compilation into perf build")
>> Cc: Peter Zijlstra <peterz@infradead.org>
>> Cc: Ingo Molnar <mingo@redhat.com>
>> Cc: Jiri Olsa <jolsa@kernel.org>
>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>> ---
>> tools/perf/Makefile.perf | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
>> index 8fc24824705e..6defd9b00bc4 100644
>> --- a/tools/perf/Makefile.perf
>> +++ b/tools/perf/Makefile.perf
>> @@ -512,7 +512,7 @@ $(LIBJVMTI_IN): FORCE
>> $(Q)$(MAKE) -f $(srctree)/tools/build/Makefile.build dir=jvmti obj=jvmti
>>
>> $(OUTPUT)$(LIBJVMTI): $(LIBJVMTI_IN)
>> - $(QUIET_LINK)$(CC) -shared -Wl,-soname -Wl,$(LIBJVMTI) -o $@ $< -lelf -lrt
>> + $(QUIET_LINK)$(CC) -shared -Wl,-soname -Wl,$(LIBJVMTI) -o $@ $< $(EXTLIBS) -lrt
>> endif
>
> hm, do we need -lelf -lrt at all? can't see reason for that
I agree as it links well without libelf. I was not sure if enabling
libelf has any issue removing it, hence I retained. I will remove both
and repost. Thanks for having a look.
--
Regards,
Sudeep
next prev parent reply other threads:[~2017-01-04 15:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 13:52 Sudeep Holla
2017-01-04 14:45 ` Jiri Olsa
2017-01-04 15:45 ` Sudeep Holla [this message]
2017-01-04 15:56 ` [PATCH v2] " Sudeep Holla
2017-01-04 16:06 ` Jiri Olsa
2017-01-04 16:08 ` Sudeep Holla
2017-01-04 16:18 ` Sudeep Holla
2017-01-04 17:19 ` Jiri Olsa
2017-01-04 17:26 ` Sudeep Holla
2017-01-04 17:30 ` [PATCH v3] " Sudeep Holla
2017-01-04 17:35 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5aa63b9b-1479-8dc9-d505-56a73e7fd9ee@arm.com \
--to=sudeep.holla@arm.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®