[PATCH] cpuidle: haltpoll: Only define guest_halt_poll_ns tracepoint when used

[PATCH] cpuidle: haltpoll: Only define guest_halt_poll_ns tracepoint when used

[Steven Rostedt]

From: Steven Rostedt <rostedt@goodmis.org>

Tracepoints that are defined take up around 5K each, even if they are not
used. When a tracepoint is used only in code when a specific config is
enabled, their definition must also be only defined when the same config
is enabled otherwise it wastes memory.

The tracepoint guest_halt_poll_ns is only used when CONFIG_CPU_IDLE_GOV_HALTPOLL
is enabled. Guard the definition of that tracepoint with the same config.

Fixes: 0da11bf0cab90 ("cpuidle: haltpoll: Add trace points for guest_halt_poll_ns grow/shrink")
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 include/trace/events/power.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/trace/events/power.h b/include/trace/events/power.h
index 370f8df2fdb4..4d17eb307b6a 100644
--- a/include/trace/events/power.h
+++ b/include/trace/events/power.h
@@ -497,6 +497,7 @@ DEFINE_EVENT(dev_pm_qos_request, dev_pm_qos_remove_request,
 	TP_ARGS(name, type, new_value)
 );
 
+#ifdef CONFIG_CPU_IDLE_GOV_HALTPOLL
 TRACE_EVENT(guest_halt_poll_ns,
 
 	TP_PROTO(bool grow, unsigned int new, unsigned int old),
@@ -525,6 +526,8 @@ TRACE_EVENT(guest_halt_poll_ns,
 	trace_guest_halt_poll_ns(true, new, old)
 #define trace_guest_halt_poll_ns_shrink(new, old) \
 	trace_guest_halt_poll_ns(false, new, old)
+#endif /* CONFIG_CPU_IDLE_GOV_HALTPOLL */
+
 #endif /* _TRACE_POWER_H */
 
 /* This part must be outside protection */
-- 
2.53.0

Re: [PATCH] cpuidle: haltpoll: Only define guest_halt_poll_ns tracepoint when used

[Wysocki, Rafael J]

On 10/22/2026 9:33 PM, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@goodmis.org>
>
> Tracepoints that are defined take up around 5K each, even if they are not
> used. When a tracepoint is used only in code when a specific config is
> enabled, their definition must also be only defined when the same config
> is enabled otherwise it wastes memory.
>
> The tracepoint guest_halt_poll_ns is only used when CONFIG_CPU_IDLE_GOV_HALTPOLL
> is enabled. Guard the definition of that tracepoint with the same config.
>
> Fixes: 0da11bf0cab90 ("cpuidle: haltpoll: Add trace points for guest_halt_poll_ns grow/shrink")
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Thanks!


> ---
>   include/trace/events/power.h | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/include/trace/events/power.h b/include/trace/events/power.h
> index 370f8df2fdb4..4d17eb307b6a 100644
> --- a/include/trace/events/power.h
> +++ b/include/trace/events/power.h
> @@ -497,6 +497,7 @@ DEFINE_EVENT(dev_pm_qos_request, dev_pm_qos_remove_request,
>   	TP_ARGS(name, type, new_value)
>   );
>   
> +#ifdef CONFIG_CPU_IDLE_GOV_HALTPOLL
>   TRACE_EVENT(guest_halt_poll_ns,
>   
>   	TP_PROTO(bool grow, unsigned int new, unsigned int old),
> @@ -525,6 +526,8 @@ TRACE_EVENT(guest_halt_poll_ns,
>   	trace_guest_halt_poll_ns(true, new, old)
>   #define trace_guest_halt_poll_ns_shrink(new, old) \
>   	trace_guest_halt_poll_ns(false, new, old)
> +#endif /* CONFIG_CPU_IDLE_GOV_HALTPOLL */
> +
>   #endif /* _TRACE_POWER_H */
>   
>   /* This part must be outside protection */

Re: [PATCH] cpuidle: haltpoll: Only define guest_halt_poll_ns tracepoint when used

[Steven Rostedt]

On Thu, 22 Oct 2026 21:54:09 +0200
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com> wrote:

> On 10/22/2026 9:33 PM, Steven Rostedt wrote:
> > From: Steven Rostedt <rostedt@goodmis.org>
> >
> > Tracepoints that are defined take up around 5K each, even if they are not
> > used. When a tracepoint is used only in code when a specific config is
> > enabled, their definition must also be only defined when the same config
> > is enabled otherwise it wastes memory.
> >
> > The tracepoint guest_halt_poll_ns is only used when CONFIG_CPU_IDLE_GOV_HALTPOLL
> > is enabled. Guard the definition of that tracepoint with the same config.
> >
> > Fixes: 0da11bf0cab90 ("cpuidle: haltpoll: Add trace points for guest_halt_poll_ns grow/shrink")
> > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>  
> 
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Thanks!

Want me to take this through my tree, or do you want to take it?

-- Steve

Re: [PATCH] cpuidle: haltpoll: Only define guest_halt_poll_ns tracepoint when used

[Wysocki, Rafael J]

On 10/22/2026 10:00 PM, Steven Rostedt wrote:
> On Thu, 22 Oct 2026 21:54:09 +0200
> "Wysocki, Rafael J" <rafael.j.wysocki@intel.com> wrote:
>
>> On 10/22/2026 9:33 PM, Steven Rostedt wrote:
>>> From: Steven Rostedt <rostedt@goodmis.org>
>>>
>>> Tracepoints that are defined take up around 5K each, even if they are not
>>> used. When a tracepoint is used only in code when a specific config is
>>> enabled, their definition must also be only defined when the same config
>>> is enabled otherwise it wastes memory.
>>>
>>> The tracepoint guest_halt_poll_ns is only used when CONFIG_CPU_IDLE_GOV_HALTPOLL
>>> is enabled. Guard the definition of that tracepoint with the same config.
>>>
>>> Fixes: 0da11bf0cab90 ("cpuidle: haltpoll: Add trace points for guest_halt_poll_ns grow/shrink")
>>> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
>> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>
>> Thanks!
> Want me to take this through my tree, or do you want to take it?

Please feel free to take it.

Rafael