Re: [PATCH 2/4] dt-bindings: media: qcom,sm8150-camss: Add SM8150 CAMSS

[Bryan O'Donoghue <bryan.odonoghue@linaro.org>]

On 06/11/2026 03:06, Andrew Gigena wrote:
> Hi Vladimir, Bryan,
> 
> Thank you both for the review and for taking the time to explain the
> direction.
> 
> Vladimir: I understand your point about the stand-alone CSI2 PHY model,
> and I agree that is where CAMSS should go. I hope this series does not
> give the impression of entrenching the legacy description; that is not
> my intention. My concern is that I don't think I can do the PHY-API
> conversion properly within this series: as far as I can see,
> qcom-mipi-csi2 currently only carries the x1e80100/glymur
> configuration and no upstream DTS uses the PHY-API path yet to take as
> a reference point.
> Converting SM8150 would also affect the other CAMSS SoCs that
> still use the legacy description, so it looks like a separate and
> larger piece of work.
> 
> If I'm missing something, or if there is an existing branch or series I
> should base that work on, I would be grateful for a pointer. I would
> also be glad to help with the conversion as a follow-up if that is the
> preferred path.
> 
> Bryan: as the CAMSS maintainer, could you let me know what you would
> like me to do for this series? I am happy to keep the legacy CSIPHY
> description for now and follow up with the PHY-API conversion, or to
> fold it into this series if you think that is the right thing. I will
> follow your guidance.
> 
> This is my first submission, so I appreciate the patience.
> 
> In the meantime, I will send v2 with the review fixes so the series
> does not stall.
> 
> Thanks,

A) No top posting pretty please with sugar on top.

B) Since we are reusing an existing PHY init sequence there is no need
    to port all of that stuff into drivers/phy right now

There are several complexities involved in porting existing bindings a 
new topology whilst supporting the old.

TBH adding a single new enum to a switch is a much better immediate outcome.

Happy to take a SoC enablement now and work-up the switch of older 
binginds to new over time.

---
bod