From: David Lechner <dlechner@baylibre.com>
To: Archit Anant <architanant5@gmail.com>, jic23@kernel.org
Cc: lars@metafoo.de, Michael.Hennerich@analog.com,
nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 4/5] iio: adc: ad799x: cache regulator voltages during probe
Date: Sat, 4 Apr 2026 11:04:41 -0500 [thread overview]
Message-ID: <1fdd057a-3234-442c-b1fc-88bfcbe542b4@baylibre.com> (raw)
In-Reply-To: <20260403080614.14213-5-architanant5@gmail.com>
On 4/3/26 3:06 AM, Archit Anant wrote:
> Since the reference voltage for this ADC is not expected to
> change at runtime, determine the active reference voltage (either VREF
> or VCC) during probe() and cache it in a single variable in the state
> structure.
>
> This improves the performance of ad799x_read_raw() and removes the
> dependency on the regulator pointers during fast-path reads.
To make this claim, it should be backed up by performance measurements.
I would drop it since I don't think it would actually make a measurable
difference and it is not in a hot path anyway.
next prev parent reply other threads:[~2026-04-04 16:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 8:06 [PATCH v7 0/5] iio: adc: ad799x: modernize resource management Archit Anant
2026-04-03 8:06 ` [PATCH v7 1/5] iio: adc: ad799x: sort headers alphabetically Archit Anant
2026-04-03 8:06 ` [PATCH v7 2/5] iio: adc: ad799x: use local device pointer in probe Archit Anant
2026-04-03 8:06 ` [PATCH v7 3/5] iio: adc: ad799x: use a static buffer for scan data Archit Anant
2026-04-03 8:06 ` [PATCH v7 4/5] iio: adc: ad799x: cache regulator voltages during probe Archit Anant
2026-04-04 16:04 ` David Lechner [this message]
2026-04-03 8:06 ` [PATCH v7 5/5] iio: adc: ad799x: convert to fully managed resources and drop remove() Archit Anant
2026-04-04 16:09 ` David Lechner
2026-04-04 16:10 ` [PATCH v7 0/5] iio: adc: ad799x: modernize resource management David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fdd057a-3234-442c-b1fc-88bfcbe542b4@baylibre.com \
--to=dlechner@baylibre.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=architanant5@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®