From: John Garry <john.g.garry@oracle.com>
To: yangxingui <yangxingui@huawei.com>,
liyihang9@huawei.com, yanaijie@huawei.com
Cc: jejb@linux.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxarm@huawei.com, prime.zeng@huawei.com,
liuyonglong@huawei.com, kangfenglong@huawei.com,
liyangyang20@huawei.com, f.fangjian@huawei.com,
xiabing14@h-partners.com
Subject: Re: [PATCH v3 1/3] scsi: hisi_sas: Enable force phy when SATA disk directly connected
Date: Mon, 10 Mar 2025 17:45:02 +0000 [thread overview]
Message-ID: <1fe3bb6b-1f7a-4188-83a3-f4c62e2a963d@oracle.com> (raw)
In-Reply-To: <d0a6b502-328b-2f83-3cdf-55c1effd80c1@huawei.com>
On 10/03/2025 13:09, yangxingui wrote:
> On 2025/2/25 16:19, John Garry wrote:
>> On 25/02/2025 01:48, yangxingui wrote:
>>>>
>>>>
>>>> pm8001 sends sas_notify_port_event(sas_phy, PORTE_LINK_RESET_ERR,)
>>>> link reset errors - can you consider doing that in
>>>> hisi_sas_update_port_id() when you find an inconstant port id?
>>> Currently during phyup, the hw port id may change, and the
>>> corresponding hisi_sas_port.id and the port id in itct are not
>>> updated synchronously. The problem caused is not a link error, so we
>>> don't need deform port, just update the port id when phyup.
>>
>> Sure, but I am just trying to keep this simple. If you deform and
>> reform the port - and so lose and find the disk (which does the itct
>> config) - will that solve the problem?
>>
> We found that we need to perform lose and find for all devices on the
> port including the local phy and the remote phy. This process still
> requires traversing the phy information corresponding to all devices to
> reset and it is also necessary to consider that there is a race between
> device removal and the current process. it looks similar to solution of
> update port id directly. And there will be the problem mentioned above.
> e.g, during error handling, the recovery state will last for more than
> 15 seconds, affecting the performance of other disks on the same host.
How do you even detect the port id inconsistency for the device attached
at the remote phy? For this series, you could detect it at the phy
up/down handler for the directly attached device - how would it be
triggered for the remote phy?
John
next prev parent reply other threads:[~2025-03-10 17:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 13:05 [PATCH v3 0/3] scsi: hisi_sas: Fixed IO error caused by port id not updated Xingui Yang
2025-02-20 13:05 ` [PATCH v3 1/3] scsi: hisi_sas: Enable force phy when SATA disk directly connected Xingui Yang
2025-02-20 17:35 ` John Garry
2025-02-21 1:59 ` yangxingui
2025-02-24 8:29 ` John Garry
2025-02-24 9:36 ` yangxingui
2025-02-24 12:21 ` John Garry
2025-02-24 13:12 ` yangxingui
2025-02-24 17:34 ` John Garry
2025-02-25 1:48 ` yangxingui
2025-02-25 8:19 ` John Garry
2025-02-25 9:35 ` yangxingui
2025-02-26 8:57 ` John Garry
2025-02-27 8:33 ` yangxingui
2025-03-04 9:48 ` John Garry
2025-03-05 8:16 ` yangxingui
2025-03-05 16:15 ` John Garry
2025-03-06 1:44 ` yangxingui
2025-03-10 13:09 ` yangxingui
2025-03-10 17:45 ` John Garry [this message]
2025-03-11 1:53 ` yangxingui
2025-03-12 9:44 ` yangxingui
2025-03-12 11:19 ` John Garry
2025-02-20 13:05 ` [PATCH v3 2/3] scsi: libsas: Move sas_put_device() to libsas.h Xingui Yang
2025-02-21 2:36 ` Jason Yan
2025-02-20 13:05 ` [PATCH v3 3/3] scsi: hisi_sas: Fixed IO error caused by port id not updated Xingui Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fe3bb6b-1f7a-4188-83a3-f4c62e2a963d@oracle.com \
--to=john.g.garry@oracle.com \
--cc=f.fangjian@huawei.com \
--cc=jejb@linux.ibm.com \
--cc=kangfenglong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=liyangyang20@huawei.com \
--cc=liyihang9@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=prime.zeng@huawei.com \
--cc=xiabing14@h-partners.com \
--cc=yanaijie@huawei.com \
--cc=yangxingui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®