mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Corey Minyard <minyard@acm.org>
To: Colin King <colin.king@canonical.com>,
	openipmi-developer@lists.sourceforge.net
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][ipmi-next] ipmi_si: fix memory leak on new_smi
Date: Tue, 17 Oct 2017 15:47:34 -0500	[thread overview]
Message-ID: <1fe921ca-73d9-6ccf-d7dc-8174340369ae@acm.org> (raw)
In-Reply-To: <20171017155452.24807-1-colin.king@canonical.com>

On 10/17/2017 10:54 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The error exit path omits kfree'ing the allocated new_smi, causing a memory
> leak.  Fix this by kfree'ing new_smi.

Thanks, queued for the next release.

-corey

> Detected by CoverityScan, CID#14582571 ("Resource Leak")
>
> Fixes: 7e030d6dff71 ("ipmi: Prefer ACPI system interfaces over SMBIOS ones")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   drivers/char/ipmi/ipmi_si_intf.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index 55e0c42bee4d..4c16af64f73a 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -2004,6 +2004,7 @@ int ipmi_si_add_smi(struct si_sm_io *io)
>   				 ipmi_addr_src_to_str(new_smi->io.addr_source),
>   				 si_to_str[new_smi->io.si_type]);
>   			rv = -EBUSY;
> +			kfree(new_smi);
>   			goto out_err;
>   		}
>   	}

      reply	other threads:[~2017-10-17 20:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-17 15:54 Colin King
2017-10-17 20:47 ` Corey Minyard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1fe921ca-73d9-6ccf-d7dc-8174340369ae@acm.org \
    --to=minyard@acm.org \
    --cc=colin.king@canonical.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®