[PATCH 2/6] clk: qoriq: Fix clock reference leak in input_clock_by_index()

[PATCH 2/6] clk: qoriq: Fix clock reference leak in input_clock_by_index()

[Wentao Liang]

input_clock_by_index() obtains a consumer clock with of_clk_get() and
hands it to input_clock(), which only uses __clk_get_name() to read the
clock name and then registers a new fixed factor clock.  The consumer
clock itself is discarded without clk_put(), so the reference returned
by of_clk_get() is never released.

Release the reference with clk_put() once input_clock() is done with
the clock, mirroring the pattern used by of_clk_get_parent_name().

Fixes: 80b4ae7acea4 ("clk: qoriq: Separate root input clock for core PLLs on ls1012a")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
 drivers/clk/clk-qoriq.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c
index 2524c5c0eb46..2ed8f93bc861 100644
--- a/drivers/clk/clk-qoriq.c
+++ b/drivers/clk/clk-qoriq.c
@@ -1135,13 +1135,16 @@ static struct clk __init *input_clock_by_name(const char *name,
 
 static struct clk __init *input_clock_by_index(const char *name, int idx)
 {
-	struct clk *clk;
+	struct clk *clk, *ret;
 
 	clk = of_clk_get(clockgen.node, 0);
 	if (IS_ERR(clk))
 		return clk;
 
-	return input_clock(name, clk);
+	ret = input_clock(name, clk);
+	clk_put(clk);
+
+	return ret;
 }
 
 static struct clk * __init create_sysclk(const char *name)
-- 
2.34.1

Re: [PATCH 2/6] clk: qoriq: Fix clock reference leak in input_clock_by_index()

[Jerome Brunet]

On mar. 15 sept. 2026 at 04:28, Wentao Liang <vulab@iscas.ac.cn> wrote:

> input_clock_by_index() obtains a consumer clock with of_clk_get() and
> hands it to input_clock(), which only uses __clk_get_name() to read the
> clock name and then registers a new fixed factor clock.  The consumer
> clock itself is discarded without clk_put(), so the reference returned
> by of_clk_get() is never released.
>
> Release the reference with clk_put() once input_clock() is done with
> the clock, mirroring the pattern used by of_clk_get_parent_name().
>
> Fixes: 80b4ae7acea4 ("clk: qoriq: Separate root input clock for core PLLs on ls1012a")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>

This is PATCH 2 out 6 but there is not thread, cover letter or other
patches. I can't tell if there is a context I should be aware of.

Please check how you've send this. Consider using b4.

> ---
>  drivers/clk/clk-qoriq.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c
> index 2524c5c0eb46..2ed8f93bc861 100644
> --- a/drivers/clk/clk-qoriq.c
> +++ b/drivers/clk/clk-qoriq.c
> @@ -1135,13 +1135,16 @@ static struct clk __init *input_clock_by_name(const char *name,
>  
>  static struct clk __init *input_clock_by_index(const char *name, int idx)
>  {
> -	struct clk *clk;
> +	struct clk *clk, *ret;
>  
>  	clk = of_clk_get(clockgen.node, 0);
>  	if (IS_ERR(clk))
>  		return clk;
>  
> -	return input_clock(name, clk);
> +	ret = input_clock(name, clk);
> +	clk_put(clk);
> +
> +	return ret;
>  }
>  
>  static struct clk * __init create_sysclk(const char *name)
> -- 
> 2.34.1
>

-- 
Jerome