From: Jerome Brunet <jbrunet@baylibre.com>
To: Johan Hovold <johan@kernel.org>
Cc: Leon Romanovsky <leon@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dave Ertman <david.m.ertman@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] driver core: auxiliary bus: fix OF node leak
Date: Tue, 08 Jul 2025 16:38:21 +0200 [thread overview]
Message-ID: <1jjz4irbmq.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <aGztOnNKu3gvFH2_@hovoldconsulting.com> (Johan Hovold's message of "Tue, 8 Jul 2025 12:04:42 +0200")
On Tue 08 Jul 2025 at 12:04, Johan Hovold <johan@kernel.org> wrote:
> On Tue, Jul 08, 2025 at 12:59:08PM +0300, Leon Romanovsky wrote:
>> On Tue, Jul 08, 2025 at 10:46:54AM +0200, Johan Hovold wrote:
>> > Make sure to drop the OF node reference taken when creating an auxiliary
>> > device using auxiliary_device_create() when the device is later
>> > released.
>>
>> I'm probably missing something, but random grep for the
>> device_set_of_node_from_dev() callers shows that none of them are
>> calling to of_node_put() explicitly.
>
> Yeah, the platform bus code takes care of dropping the reference for
> platform devices.
There is an of_node_get() that needs balancing indeed, Thanks
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
>
> Johan
--
Jerome
next prev parent reply other threads:[~2025-07-08 14:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 8:46 Johan Hovold
2025-07-08 9:59 ` Leon Romanovsky
2025-07-08 10:04 ` Johan Hovold
2025-07-08 14:38 ` Jerome Brunet [this message]
2025-07-08 14:39 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1jjz4irbmq.fsf@starbuckisacylon.baylibre.com \
--to=jbrunet@baylibre.com \
--cc=dakr@kernel.org \
--cc=david.m.ertman@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=ira.weiny@intel.com \
--cc=johan@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®