Re: [PATCH] driver core: auxiliary bus: fix OF node leak

[Leon Romanovsky <leon@kernel.org>]

On Tue, Jul 08, 2025 at 10:46:54AM +0200, Johan Hovold wrote:
> Make sure to drop the OF node reference taken when creating an auxiliary
> device using auxiliary_device_create() when the device is later
> released.

I'm probably missing something, but random grep for the
device_set_of_node_from_dev() callers shows that none of them are
calling to of_node_put() explicitly.

Thanks

> 
> Fixes: eaa0d30216c1 ("driver core: auxiliary bus: add device creation helpers")
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
>  drivers/base/auxiliary.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/base/auxiliary.c b/drivers/base/auxiliary.c
> index dba7c8e13a53..6bdefebf3609 100644
> --- a/drivers/base/auxiliary.c
> +++ b/drivers/base/auxiliary.c
> @@ -399,6 +399,7 @@ static void auxiliary_device_release(struct device *dev)
>  {
>  	struct auxiliary_device *auxdev = to_auxiliary_dev(dev);
>  
> +	of_node_put(dev->of_node);
>  	kfree(auxdev);
>  }
>  
> @@ -435,6 +436,7 @@ struct auxiliary_device *auxiliary_device_create(struct device *dev,
>  
>  	ret = auxiliary_device_init(auxdev);
>  	if (ret) {
> +		of_node_put(auxdev->dev.of_node);
>  		kfree(auxdev);
>  		return NULL;
>  	}
> -- 
> 2.49.0
>