From: Jerome Brunet <jbrunet@baylibre.com>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
patches@lists.linux.dev, Jian Hu <jian.hu@amlogic.com>,
Dmitry Rokosov <ddrokosov@sberdevices.ru>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: Re: [PATCH] clk: meson: a1: Staticize rtc clk
Date: Mon, 12 Jun 2023 22:03:11 +0200 [thread overview]
Message-ID: <1jzg54fnvw.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <20230612182332.371003-1-sboyd@kernel.org>
On Mon 12 Jun 2023 at 11:23, Stephen Boyd <sboyd@kernel.org> wrote:
> Sparse rightly complains that this symbol is supposed to be static.
>
> Cc: Jian Hu <jian.hu@amlogic.com>
> Cc: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Fixes: 84af914404db ("clk: meson: a1: add Amlogic A1 Peripherals clock controller driver")
> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
Sorry this got through.
> ---
> drivers/clk/meson/a1-peripherals.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/meson/a1-peripherals.c b/drivers/clk/meson/a1-peripherals.c
> index b320134fefeb..75dfae210fe5 100644
> --- a/drivers/clk/meson/a1-peripherals.c
> +++ b/drivers/clk/meson/a1-peripherals.c
> @@ -218,7 +218,7 @@ static struct clk_regmap rtc_32k_sel = {
> },
> };
>
> -struct clk_regmap rtc = {
> +static struct clk_regmap rtc = {
> .data = &(struct clk_regmap_gate_data){
> .offset = RTC_BY_OSCIN_CTRL0,
> .bit_idx = 30,
next prev parent reply other threads:[~2023-06-12 20:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 18:23 Stephen Boyd
2023-06-12 20:03 ` Jerome Brunet [this message]
2023-06-12 20:19 ` Martin Blumenstingl
2023-06-12 21:30 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1jzg54fnvw.fsf@starbuckisacylon.baylibre.com \
--to=jbrunet@baylibre.com \
--cc=ddrokosov@sberdevices.ru \
--cc=jian.hu@amlogic.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=patches@lists.linux.dev \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®