mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Jeff Garzik <jgarzik@mandrakesoft.com>
Cc: "Hen, Shmulik" <shmulik.hen@intel.com>,
	"'LKML'" <linux-kernel@vger.kernel.org>,
	"'LNML'" <linux-net@vger.kernel.org>
Subject: Re: Locking Between User Context and Soft IRQs in 2.4.0
Date: Sat, 4 Nov 2000 11:19:09 +0100	[thread overview]
Message-ID: <20001104111909.A11500@gruyere.muc.suse.de> (raw)
In-Reply-To: <07E6E3B8C072D211AC4100A0C9C5758302B27077@hasmsx52.iil.intel.com> <3A03DABD.AF4B9AD5@mandrakesoft.com>
In-Reply-To: <3A03DABD.AF4B9AD5@mandrakesoft.com>; from jgarzik@mandrakesoft.com on Sat, Nov 04, 2000 at 04:45:33AM -0500

On Sat, Nov 04, 2000 at 04:45:33AM -0500, Jeff Garzik wrote:
> 
> > *       What about dev->open and dev->stop ?
> 
> Sleep all you want, we'll leave the light on for ya.


... but make sure you have no module unload races (or at least not too
huge holes, some are probably unavoidable with the current network
driver interface, e.g. without moving module count management a bit up). 
This means you should do MOD_INC_USE_COUNT very early at least to
minimize the windows (and DEC_USE_COUNT very late) 

> dev->do_ioctl:
> 	Locking: Inside rtnl_lock() semaphore.
> 	Sleeping: OK

Just make sure you lock against your interrupt and xmit threads.

> 	Locking: Inside dev->xmit_lock spinlock.
> 	Sleeping: NO[1]
> 
> 
> NOTE [1]: On principle, you should not sleep when a spinlock is held.
> However, since this spinlock is per-net-device, we only block ourselves
> if we sleep, so the effect is mitigated.

Sounds like dangerous advice.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

  reply	other threads:[~2000-11-04 10:19 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-10-30 14:10 Hen, Shmulik
2000-11-04  9:45 ` Jeff Garzik
2000-11-04 10:19   ` Andi Kleen [this message]
2000-11-04 15:36     ` Jeff Garzik
2000-11-04 16:56       ` Andi Kleen
2000-11-04 17:07         ` Jeff Garzik
2000-11-05  0:38           ` Andi Kleen
2000-11-05  1:28             ` Andrew Morton
2000-11-05  1:52               ` Andrew Morton
2000-11-05  2:32               ` Andi Kleen
2000-11-05  3:39               ` Keith Owens
2000-11-05  3:47                 ` Keith Owens
2000-11-05 11:45                   ` Andrew Morton
2000-11-06  2:20                     ` Paul Gortmaker
2000-11-06  9:55                       ` Andrew Morton
2000-11-06 10:05                         ` Jeff Garzik
2000-11-06 12:37                           ` Keith Owens
2000-11-06 12:49                             ` Jeff Garzik
2000-11-06 12:58                               ` Keith Owens
2000-11-06 13:09                                 ` Jeff Garzik
2000-11-06 13:18                                   ` Keith Owens
2000-11-07  2:23                         ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20001104111909.A11500@gruyere.muc.suse.de \
    --to=ak@suse.de \
    --cc=jgarzik@mandrakesoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    --cc=shmulik.hen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®