Re: pdev_enable_device no longer used ?

[Jamie Lokier <lk@tantalophile.demon.co.uk>]

Here are a few more:

 net/acenic.c: pci_write_config_byte(ap->pdev, PCI_CACHE_LINE_SIZE,
 net/gmac.c: PCI_CACHE_LINE_SIZE, 8);
 scsi/sym53c8xx.c: printk(NAME53C8XX ": PCI_CACHE_LINE_SIZE set to %d (fix-up).\n",
 video/pm2fb.c: WR32(p->pci_config, PCI_CACHE_LINE_SIZE, 0xff00);

-- Jamie

davej@suse.de wrote:
> > > 1. Is there reason for the drivers to be setting this themselves
> > >    to hardcoded values ?
> > 
> > Definitely not unless the devices are buggy and need a work-around.
> 
> Maybe that's the case. The culprits are mostly IDE interfaces. Andre ?
> 
> drivers/ide/cmd64x.c:   (void) pci_write_config_byte(dev,PCI_CACHE_LINE_SIZE, 0x10);
> drivers/ide/cs5530.c:   pci_write_config_byte(cs5530_0,PCI_CACHE_LINE_SIZE, 0x04);
> drivers/ide/hpt366.c:   pci_write_config_byte(dev,PCI_CACHE_LINE_SIZE, 0x08);
> drivers/ide/ns87415.c:  (void) pci_write_config_byte(dev,PCI_CACHE_LINE_SIZE, 0x10);
> 
> drivers/atm/eni.c:      pci_write_config_byte(eni_dev->pci_dev,PCI_CACHE_LINE_SIZE, 0x10);
> drivers/media/video/planb.c:    pci_write_config_byte (pdev,PCI_CACHE_LINE_SIZE, 0x8);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/