mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* kernel-doc minor fix
@ 2000-12-16 14:41 Jani Monoses
  2000-12-17 16:22 ` Simon Huggins
  0 siblings, 1 reply; 3+ messages in thread
From: Jani Monoses @ 2000-12-16 14:41 UTC (permalink / raw)
  To: twaugh; +Cc: linux-kernel


Hi 

	inline docs are not generated for functions which return a 'const'
because this modifier is not checked for (only inline extern and static)
when verifying the function prototype.
This patch fixes it and hopefully doesn't break anything else(I am
Perl----)

Jani.

--- /usr/src/linux/scripts/kernel-doc	Tue Dec 12 11:25:59 2000
+++ kernel-doc	Sat Dec 16 15:53:17 2000
@@ -664,10 +664,11 @@
 
 ##
 # takes a function prototype and spits out all the details
-# stored in the global arrays/hsahes.
+# stored in the global arrays/hashes.
 sub dump_function {
     my $prototype = shift @_;
 
+    $prototype =~ s/^const+ //;
     $prototype =~ s/^static+ //;
     $prototype =~ s/^extern+ //;
     $prototype =~ s/^inline+ //;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: kernel-doc minor fix
  2000-12-16 14:41 kernel-doc minor fix Jani Monoses
@ 2000-12-17 16:22 ` Simon Huggins
  2000-12-18  9:04   ` Jani Monoses
  0 siblings, 1 reply; 3+ messages in thread
From: Simon Huggins @ 2000-12-17 16:22 UTC (permalink / raw)
  To: linux-kernel; +Cc: twaugh

On Sat, Dec 16, 2000 at 04:41:44PM +0200, Jani Monoses wrote:
> --- /usr/src/linux/scripts/kernel-doc	Tue Dec 12 11:25:59 2000
> +++ kernel-doc	Sat Dec 16 15:53:17 2000
> @@ -664,10 +664,11 @@

>  ##
>  # takes a function prototype and spits out all the details
> -# stored in the global arrays/hsahes.
> +# stored in the global arrays/hashes.
>  sub dump_function {
>      my $prototype = shift @_;

> +    $prototype =~ s/^const+ //;
>      $prototype =~ s/^static+ //;
>      $prototype =~ s/^extern+ //;
>      $prototype =~ s/^inline+ //;

Since when did C accept constttttttttttttttttttt and staticcccccccc?
etc.

Should that be " +" not "+ " or is someone just trying to confuse me?
Or did someone try to mean s/foo//g by adding a +?


Yours confusedly,

Simon.

-- 
[ "Therapy is expensive. Popping bubble wrap is cheap. You choose."    ]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: kernel-doc minor fix
  2000-12-17 16:22 ` Simon Huggins
@ 2000-12-18  9:04   ` Jani Monoses
  0 siblings, 0 replies; 3+ messages in thread
From: Jani Monoses @ 2000-12-18  9:04 UTC (permalink / raw)
  To: Simon Huggins; +Cc: linux-kernel



On Sun, 17 Dec 2000, Simon Huggins wrote:

> On Sat, Dec 16, 2000 at 04:41:44PM +0200, Jani Monoses wrote:
> > +    $prototype =~ s/^const+ //;
> Yours confusedly,
> 
> Simon.

Hi 

I can't answer to your question but this patch is not good anyway as Tim
pointed out to me.


Jani.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2000-12-18  9:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2000-12-16 14:41 kernel-doc minor fix Jani Monoses
2000-12-17 16:22 ` Simon Huggins
2000-12-18  9:04   ` Jani Monoses

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®