* test13-pre5: Double flush_cache_page?
@ 2000-12-29 11:52 Russell King
0 siblings, 0 replies; only message in thread
From: Russell King @ 2000-12-29 11:52 UTC (permalink / raw)
To: linux-kernel; +Cc: riel
Hi,
Is the following really intentional?
vmscan.c:122:
flush_cache_page(vma, address);
if (!pte_dirty(pte))
goto drop_pte;
...
flush_cache_page(vma, address);
if (page->mapping) {
Nothing accesses the actual page between the two flush_cache_page() calls,
the first one was added in test13-pre5. Should test13-pre5 have removed
the second instance?
_____
|_____| ------------------------------------------------- ---+---+-
| | Russell King rmk@arm.linux.org.uk --- ---
| | | | http://www.arm.linux.org.uk/personal/aboutme.html / / |
| +-+-+ --- -+-
/ | THE developer of ARM Linux |+| /|\
/ | | | --- |
+-+-+ ------------------------------------------------- /\\\ |
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2000-12-29 13:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2000-12-29 11:52 test13-pre5: Double flush_cache_page? Russell King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®