* PATCH: test13-pre5/drivers/sound/via82cxxx_audio.c did not compile
@ 2000-12-30 4:09 Adam J. Richter
2000-12-30 4:26 ` Linus Torvalds
0 siblings, 1 reply; 2+ messages in thread
From: Adam J. Richter @ 2000-12-30 4:09 UTC (permalink / raw)
To: linux-kernel; +Cc: torvalds
[-- Attachment #1: Type: text/plain, Size: 901 bytes --]
linux-2.4.0-test13-pre5 eliminated vm_operations_struct->swapout,
but this change was not reflected in drivers/sound/via82cxxx_audio.c,
causing that file to fail to compile. I have attached what I believe
is the correct fix below.
via82cxxx_audio.c has Jeff Garzik's name on it, but I understand
that he is taking a break for a few weeks to recover from typing strain.
(Hope you recover soon, Jeff.) Consequently, I am not sure whom I should
ask to "bless" this change. So, I'll just send this to linux-kernel
and Linus and will leave it to linux-kernel readers to sound the alarm
if I botched the patch.
--
Adam J. Richter __ ______________ 4880 Stevens Creek Blvd, Suite 104
adam@yggdrasil.com \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 408 261-6631 "Free Software For The Rest Of Us."
[-- Attachment #2: sound.diffs --]
[-- Type: text/plain, Size: 450 bytes --]
--- linux-2.4.0-test13-pre5/drivers/sound/via82cxxx_audio.c Mon Oct 30 12:24:22 2000
+++ linux/drivers/sound/via82cxxx_audio.c Fri Dec 29 16:53:22 2000
@@ -1727,20 +1727,8 @@
}
-#ifndef VM_RESERVE
-static int via_mm_swapout (struct page *page, struct file *filp)
-{
- return 0;
-}
-#endif /* VM_RESERVE */
-
-
struct vm_operations_struct via_mm_ops = {
nopage: via_mm_nopage,
-
-#ifndef VM_RESERVE
- swapout: via_mm_swapout,
-#endif
};
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: PATCH: test13-pre5/drivers/sound/via82cxxx_audio.c did not compile
2000-12-30 4:09 PATCH: test13-pre5/drivers/sound/via82cxxx_audio.c did not compile Adam J. Richter
@ 2000-12-30 4:26 ` Linus Torvalds
0 siblings, 0 replies; 2+ messages in thread
From: Linus Torvalds @ 2000-12-30 4:26 UTC (permalink / raw)
To: Adam J. Richter; +Cc: linux-kernel
On Fri, 29 Dec 2000, Adam J. Richter wrote:
>
> linux-2.4.0-test13-pre5 eliminated vm_operations_struct->swapout,
> but this change was not reflected in drivers/sound/via82cxxx_audio.c,
> causing that file to fail to compile. I have attached what I believe
> is the correct fix below.
Actually, the right fix is to change all VM_RESERVE to VM_RESERVED (ie add
a "D" at the end), at which point it should compile and work fine..
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2000-12-30 4:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2000-12-30 4:09 PATCH: test13-pre5/drivers/sound/via82cxxx_audio.c did not compile Adam J. Richter
2000-12-30 4:26 ` Linus Torvalds
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®