From: Mikael Pettersson <mikpe@csd.uu.se>
To: jgarzik@mandrakesoft.com, mea@nic.funet.fi
Cc: linux-kernel@vger.kernel.org
Subject: 2.4.0 tulip bug (was: And oh, btw..)
Date: Fri, 5 Jan 2001 16:23:13 +0100 (MET) [thread overview]
Message-ID: <200101051523.QAA26873@harpo.it.uu.se> (raw)
On Thu, 4 Jan 2001, Linus Torvalds wrote:
>Changes since the prerelease:
>...
>Matti Aarnio:
> - teach tulip driver about media types 5 and 6
This part of the patch introduces a bug in 2.4.0, as noticed by gcc:
media.c: In function `tulip_select_media':
media.c:268: warning: unused variable `csr15val'
media.c:268: warning: unused variable `csr15dir'
media.c:268: warning: unused variable `csr14val'
media.c:268: warning: unused variable `csr13val'
media.c:151: warning: `new_csr6' might be used uninitialized in this function
The last warning indicates a real problem. The patch adds a new
control flow path in which new_csr6 is _not_ assigned a value,
which causes the procedure's second last statement
tp->csr6 = new_csr6 | (tp->csr6 & 0xfdff) | (tp->full_duplex ? 0x0200 : 0);
to 'or' random bits into tp->csr6.
The patch also adds four unused variables, which looks rather fishy.
/Mikael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next reply other threads:[~2001-01-05 15:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-01-05 15:23 Mikael Pettersson [this message]
2001-01-05 15:38 ` Matti Aarnio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200101051523.QAA26873@harpo.it.uu.se \
--to=mikpe@csd.uu.se \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mea@nic.funet.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®