mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matti Aarnio <matti.aarnio@zmailer.org>
To: Mikael Pettersson <mikpe@csd.uu.se>
Cc: jgarzik@mandrakesoft.com, mea@nic.funet.fi, linux-kernel@vger.kernel.org
Subject: Re: 2.4.0 tulip bug (was: And oh, btw..)
Date: Fri, 5 Jan 2001 17:38:08 +0200	[thread overview]
Message-ID: <20010105173808.P12545@mea-ext.zmailer.org> (raw)
In-Reply-To: <200101051523.QAA26873@harpo.it.uu.se>
In-Reply-To: <200101051523.QAA26873@harpo.it.uu.se>; from mikpe@csd.uu.se on Fri, Jan 05, 2001 at 04:23:13PM +0100

On Fri, Jan 05, 2001 at 04:23:13PM +0100, Mikael Pettersson wrote:
> >Changes since the prerelease:
> >...
> >Matti Aarnio:
> > - teach tulip driver about media types 5 and 6
>
> This part of the patch introduces a bug in 2.4.0, as noticed by gcc:

	Oddly enough the beast works with my test specimen,
	but real analysis is still incomplete by Donald et.al.

	So far we think that if the card has MII (type 1) media,
	it could safely ignore types 5 and 6.

> The patch also adds four unused variables, which looks rather fishy.

	Indeed, it is copy&paste from somewhere else, which may
	indeed have different control flows.

	However unless you have esoteric (taiwanese) special hardware
	with those media types, it won't affect you.

> /Mikael

/Matti Aarnio
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

      reply	other threads:[~2001-01-05 15:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-01-05 15:23 Mikael Pettersson
2001-01-05 15:38 ` Matti Aarnio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010105173808.P12545@mea-ext.zmailer.org \
    --to=matti.aarnio@zmailer.org \
    --cc=jgarzik@mandrakesoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mea@nic.funet.fi \
    --cc=mikpe@csd.uu.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®