super_operations in -pre7

super_operations in -pre7

[Matthew Wilcox]

several new operations have been added to super_operations, presumably
as part of the reiserfs merge.  write_super_lockfs and unlockfs are
never called.  can we remove them?

-- 
Revolutions do not require corporate support.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: super_operations in -pre7

[Andreas Dilger]

Mattew Wilcox writes:
> several new operations have been added to super_operations, presumably
> as part of the reiserfs merge.  write_super_lockfs and unlockfs are
> never called.  can we remove them?

These operations were added to co-ordinate filesystem backups/snapshots
for journalling filesystems (especially in conjunction with LVM).  At
some point in the future ext3 will also be using them.  However, (only
having looked at preliminary patches, and not the final 2.4.1-pre reiserfs
merge) it is bad to insert them in the middle of the super_operations
struct at this point, as it breaks every filesystem that isn't part of
the kernel.  That said, the addition of (reiserfs-specific) read_inode2
and dirty_inode pointers also break all non-kernel filesystems.  Argh!

Cheers, Andreas
-- 
Andreas Dilger  \ "If a man ate a pound of pasta and a pound of antipasto,
                 \  would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/               -- Dogbert
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/