* cramfs b0rken on HIGHMEM machines
@ 2001-03-22 4:19 Ingo Oeser
2001-03-22 12:13 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: Ingo Oeser @ 2001-03-22 4:19 UTC (permalink / raw)
To: linux-fsdevel; +Cc: linux-kernel
Hi there,
just look at fs/cramfs/inode.c:cramfs_read_page()
It uses page_address instead of kmap().
I would have fixed it myself, but I don't know, how I should
kunmap() it, once we have memory pressure.
BTW: I bought an SMP machine with 1GB RAM yesterday to test such
cases and found the first BUG now.
Yes I know, that nobody build embedded machines with HIGHMEM
support, but it's still a BUG right? ;-)
Regards
Ingo Oeser
--
10.+11.03.2001 - 3. Chemnitzer LinuxTag <http://www.tu-chemnitz.de/linux/tag>
<<<<<<<<<<<< been there and had much fun >>>>>>>>>>>>
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: cramfs b0rken on HIGHMEM machines
2001-03-22 4:19 cramfs b0rken on HIGHMEM machines Ingo Oeser
@ 2001-03-22 12:13 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2001-03-22 12:13 UTC (permalink / raw)
To: Ingo Oeser; +Cc: linux-fsdevel, linux-kernel
> just look at fs/cramfs/inode.c:cramfs_read_page()
> It uses page_address instead of kmap().
>
> I would have fixed it myself, but I don't know, how I should
> kunmap() it, once we have memory pressure.
Take a look at ramfs. kmap isnt really a 'pressure' thing. You want to kunmap
the page as soon as you can. The kmap/unmap operations are fairly fast but
there is a limited pool of maps.
Alan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2001-03-22 12:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-03-22 4:19 cramfs b0rken on HIGHMEM machines Ingo Oeser
2001-03-22 12:13 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®