From: Andreas Dilger <adilger@turbolinux.com>
To: Alexander Viro <aviro@redhat.com>
Cc: "Stephen C. Tweedie" <sct@redhat.com>,
linux-fsdevel@webber.adilger.int,
Linux kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [linux-lvm] EXT2-fs panic (device lvm(58,0)):
Date: Thu, 22 Mar 2001 22:48:22 -0700 (MST) [thread overview]
Message-ID: <200103230548.f2N5mM407684@webber.adilger.int> (raw)
In-Reply-To: <Pine.LNX.4.33.0103222100370.18794-100000@devserv.devel.redhat.com> from Alexander Viro at "Mar 22, 2001 09:04:15 pm"
Al Viro writes:
> On Fri, 23 Mar 2001, Stephen C. Tweedie wrote:
> > On Wed, Mar 07, 2001 at 01:35:05PM -0700, Andreas Dilger wrote:
> > > The only remote possibility is in ext2_free_blocks() if block+count
> > > overflows a 32-bit unsigned value. Only 2 places call ext2_free_blocks()
> > > with a count != 1, and ext2_free_data() looks to be OK. The other
> > > possibility is that i_prealloc_count is bogus - that is it! Nowhere
> > > is i_prealloc_count initialized to zero AFAICS.
> > >
> > Did you ever push this to Alan and/or Linus? This looks pretty
> > important!
>
> It isn't. Check fs/inode.c::clean_inode(). Specifically,
> memset(&inode->u, 0, sizeof(inode->u));
> The thing is called both by get_empty_inode() and by get_new_inode() (the
> former - just before returning, the latter - just before calling
> ->read_inode()).
If this is the case, then all of the other zero initializations can be
removed as well. I figured that if most of the fields needed to be
zeroed, then ones _not_ being zeroed would lead to this problem.
FYI Stephen, the original poster followed up that the problem was with
an IBM SCSI RAID card...
Cheers, Andreas
--
Andreas Dilger \ "If a man ate a pound of pasta and a pound of antipasto,
\ would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/ -- Dogbert
next prev parent reply other threads:[~2001-03-23 5:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-07 20:35 Andreas Dilger
2001-03-23 1:39 ` Stephen C. Tweedie
2001-03-23 2:04 ` Alexander Viro
2001-03-23 5:48 ` Andreas Dilger [this message]
2001-03-23 11:44 ` Alexander Viro
2001-03-23 19:11 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200103230548.f2N5mM407684@webber.adilger.int \
--to=adilger@turbolinux.com \
--cc=aviro@redhat.com \
--cc=linux-fsdevel@webber.adilger.int \
--cc=linux-kernel@vger.kernel.org \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®