From: Alexander Viro <aviro@redhat.com>
To: "Stephen C. Tweedie" <sct@redhat.com>
Cc: Andreas Dilger <adilger@turbolinux.com>,
Linux kernel development list <linux-kernel@vger.kernel.org>,
Linux FS development list <linux-fsdevel@vger.kernel.org>,
Alexander Viro <aviro@redhat.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linus Torvalds <torvalds@transmeta.com>
Subject: Re: [linux-lvm] EXT2-fs panic (device lvm(58,0)):
Date: Thu, 22 Mar 2001 21:04:15 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.33.0103222100370.18794-100000@devserv.devel.redhat.com> (raw)
In-Reply-To: <20010323013914.M7756@redhat.com>
On Fri, 23 Mar 2001, Stephen C. Tweedie wrote:
> Hi,
>
> On Wed, Mar 07, 2001 at 01:35:05PM -0700, Andreas Dilger wrote:
>
> > The only remote possibility is in ext2_free_blocks() if block+count
> > overflows a 32-bit unsigned value. Only 2 places call ext2_free_blocks()
> > with a count != 1, and ext2_free_data() looks to be OK. The other
> > possibility is that i_prealloc_count is bogus - that is it! Nowhere
> > is i_prealloc_count initialized to zero AFAICS.
> >
> Did you ever push this to Alan and/or Linus? This looks pretty
> important!
It isn't. Check fs/inode.c::clean_inode(). Specifically,
memset(&inode->u, 0, sizeof(inode->u));
The thing is called both by get_empty_inode() and by get_new_inode() (the
former - just before returning, the latter - just before calling
->read_inode()).
Cheers,
Al
next prev parent reply other threads:[~2001-03-23 2:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-07 20:35 Andreas Dilger
2001-03-23 1:39 ` Stephen C. Tweedie
2001-03-23 2:04 ` Alexander Viro [this message]
2001-03-23 5:48 ` Andreas Dilger
2001-03-23 11:44 ` Alexander Viro
2001-03-23 19:11 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.33.0103222100370.18794-100000@devserv.devel.redhat.com \
--to=aviro@redhat.com \
--cc=adilger@turbolinux.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sct@redhat.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®