mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Peter T. Breuer" <ptb@it.uc3m.es>
To: "linux kernel" <linux-kernel@vger.kernel.org>
Subject: block devices don't work without plugging in 2.4.3
Date: Tue, 17 Apr 2001 18:40:27 +0200 (MET DST)	[thread overview]
Message-ID: <200104171640.f3HGeRb32326@oboe.it.uc3m.es> (raw)

Well, anyway, as far as I can tell, the following has been lost from
__make_request() in ll_rw_blk.c since the 2.4.0 days:

 out:
-       if (!q->plugged)
-               (q->request_fn)(q);
        if (freereq)

The result appears to be that if a block device has called
blk_queue_pluggable() to register a no-op plug_fn, then
q->plugged will never be set (it's the duty of the plug_fn),
and the devices registered request function wil never be called.

This behaviour is distinct from 2.4.0, where registering a 
no-op made things work fine.

Is the policy now supposed to be that we do some more work
in the "no-op"?  What am I supposed to do if I don't want
plugging(1)(2)?

(1) goes away and looks ....
(2) actually, I do want plugging, but I like to keep the
    no-plug option around so that I can benchmark the difference
    and also provide a very conservative option setting.

Peter

             reply	other threads:[~2001-04-17 16:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-04-17 16:40 Peter T. Breuer [this message]
2001-04-17 17:03 ` Jens Axboe
2001-04-19 10:39 Peter T. Breuer
2001-04-19 10:51 ` Jens Axboe
2001-04-19 11:23   ` Peter T. Breuer
2001-04-19 11:54     ` Jens Axboe
2001-04-19 12:33       ` Peter T. Breuer
2001-04-19 12:40         ` Jens Axboe
2001-04-19 13:09           ` Peter T. Breuer
2001-04-19 13:24             ` Jens Axboe
2001-04-19 13:54               ` Peter T. Breuer
2001-04-19 13:59                 ` Jens Axboe
2001-04-19 14:46                   ` Peter T. Breuer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200104171640.f3HGeRb32326@oboe.it.uc3m.es \
    --to=ptb@it.uc3m.es \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®