mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Peter T. Breuer" <ptb@it.uc3m.es>
To: "Jens Axboe" <axboe@suse.de>
Cc: "linux kernel" <linux-kernel@vger.kernel.org>
Subject: Re: block devices don't work without plugging in 2.4.3
Date: Thu, 19 Apr 2001 14:33:08 +0200 (MET DST)	[thread overview]
Message-ID: <200104191233.f3JCX8s22171@oboe.it.uc3m.es> (raw)
In-Reply-To: <20010419135417.Q16822@suse.de> from "Jens Axboe" at "Apr 19, 2001 01:54:17 pm"

"A month of sundays ago Jens Axboe wrote:"
> On Thu, Apr 19 2001, Peter T. Breuer wrote:
> > So the consensus is that I should enable plugging while the plugging
> > function is still here and do nothing when it goes? I must say I don't
> > think it should really "go", since that means I have to add a no-op
> > macro to replace it, and I don't like #ifdefs. 
> 
> The moral would be that you should never do anything. You didn't enable
> plugging with blk_queue_pluggable, only disabled it by using a noop
> plug.

I was thinking about what has to be done to allow my code to compile in
older kernels. I _believe_ (I may be mistaken) that I had to _explicitly_
disable plugging at some stage. Probably in 2.2. and possibly in 2.4.0.

On that basis, I do need a plug_fn and a blk_queue_pluggable for
compilation against those kernels, and these should both be macro'ed to
oblivion in the newest kernels. No? 

Apologies for the continued vagueness. There are a lot of states to
consider: two machine states (plugged/not plugged) and several code
states (whatever had to be done when to cause what).

Peter

  reply	other threads:[~2001-04-19 12:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-04-19 10:39 Peter T. Breuer
2001-04-19 10:51 ` Jens Axboe
2001-04-19 11:23   ` Peter T. Breuer
2001-04-19 11:54     ` Jens Axboe
2001-04-19 12:33       ` Peter T. Breuer [this message]
2001-04-19 12:40         ` Jens Axboe
2001-04-19 13:09           ` Peter T. Breuer
2001-04-19 13:24             ` Jens Axboe
2001-04-19 13:54               ` Peter T. Breuer
2001-04-19 13:59                 ` Jens Axboe
2001-04-19 14:46                   ` Peter T. Breuer
  -- strict thread matches above, loose matches on Subject: below --
2001-04-17 16:40 Peter T. Breuer
2001-04-17 17:03 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200104191233.f3JCX8s22171@oboe.it.uc3m.es \
    --to=ptb@it.uc3m.es \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®