NWFS broken on 2.4.3 -- someone removed WRITERAW

NWFS broken on 2.4.3 -- someone removed WRITERAW

[Jeff V. Merkey]

Hey guys,

Whomever removed WRITERAW has broken NWFS.  WRITE requests call
_refile_buffer() after the I/O request and take my locally created 
buffer heads and munge them back into the linux buffer cache, causing
massive memory corruption in the system.  These buffers don't belong 
in Linus' buffer cache, they are owned by my LRU and ll_rw_block 
should not be blindly filing them back into the buffer cache.

Please put something back in to allow me to write without the buffer
heads always getting filed into Linus' buffer cache.  This has 
broken NWFS on 2.4.3 and above.

As for using Linus' buffer cache, until you put in the ability to 
create logical block mapping instead of physical, I will not be 
able to use it.  Hopefully, this will make it in 2.5.  I have some 
folks trying to use this with 2.4.3 and they are dead in the water
until this gets addressed.

Thanks

Jeff

Re: NWFS broken on 2.4.3 -- someone removed WRITERAW

[Jens Axboe]

On Mon, Apr 23 2001, Jeff V. Merkey wrote:
> 
> 
> Hey guys,
> 
> Whomever removed WRITERAW has broken NWFS.  WRITE requests call
> _refile_buffer() after the I/O request and take my locally created 
> buffer heads and munge them back into the linux buffer cache, causing
> massive memory corruption in the system.  These buffers don't belong 
> in Linus' buffer cache, they are owned by my LRU and ll_rw_block 
> should not be blindly filing them back into the buffer cache.
> 
> Please put something back in to allow me to write without the buffer
> heads always getting filed into Linus' buffer cache.  This has 
> broken NWFS on 2.4.3 and above.

	bh->b_end_io = my_end_io_handler;
	submit_bh(WRITE, bh);

Be a happy camper.

-- 
Jens Axboe

Re: NWFS broken on 2.4.3 -- someone removed WRITERAW

[Jeff V. Merkey]

On Tue, Apr 24, 2001 at 12:58:09AM +0200, Jens Axboe wrote:
> On Mon, Apr 23 2001, Jeff V. Merkey wrote:
> > 
> > 
> > Hey guys,
> > 
> > Whomever removed WRITERAW has broken NWFS.  WRITE requests call
> > _refile_buffer() after the I/O request and take my locally created 
> > buffer heads and munge them back into the linux buffer cache, causing
> > massive memory corruption in the system.  These buffers don't belong 
> > in Linus' buffer cache, they are owned by my LRU and ll_rw_block 
> > should not be blindly filing them back into the buffer cache.
> > 
> > Please put something back in to allow me to write without the buffer
> > heads always getting filed into Linus' buffer cache.  This has 
> > broken NWFS on 2.4.3 and above.
> 
> 	bh->b_end_io = my_end_io_handler;
> 	submit_bh(WRITE, bh);


Jens,

Bless you.  I'll code the fix, test it, and get it out.  

Jeff

> 
> Be a happy camper.
> 
> -- 
> Jens Axboe
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/