Possible README patch

Possible README patch

[Duncan Gauld]

Hi

Information in the README file says that when patching, the -p0 option is 
used with patch (eg tar xvzf <patch>.tar.gz | patch -p0). However I have 
never got this to work as I always get something like "can't find file to 
patch at line 5". However, replacing -p0 with -p1 seems to work perfectly.
Maybe the penguin doesn't like me, but still, whenever I've downloaded 
patches I had to say -p1, not -p0...

anyone else have to do this? If so, here's a wee patch for it.. (bear with 
me, it's my first one :)

Duncan Gauld
dunkers@blueyonder.co.uk
----------------------------------------------------------------

-- README	Sat May  5 09:51:36 2001
+++ README	Sat May  5 09:52:24 2001
@@ -66,10 +66,10 @@
    install by patching, get all the newer patch files, enter the
    directory in which you unpacked the kernel source and execute:
 
-		gzip -cd patchXX.gz | patch -p0
+		gzip -cd patchXX.gz | patch -p1
 
    or
-		bzip2 -dc patchXX.bz2 | patch -p0
+		bzip2 -dc patchXX.bz2 | patch -p1
 
    (repeat xx for all versions bigger than the version of your current
    source tree, _in_order_) and you should be ok.  You may want to remove

Re: Possible README patch

[Russell King]

On Sat, May 05, 2001 at 10:04:01AM -0400, Duncan Gauld wrote:
> Information in the README file says that when patching, the -p0 option is 
> used with patch (eg tar xvzf <patch>.tar.gz | patch -p0).

You probably have done:

gzip -dc linux-2.4.XX.tar.gz | tar zvf -
cd linux
gzip -dc patchXX.gz | patch -p0

which will fail since the patch file specifies all files with a path
starting with 'linux/'.  However, the instructions in the README are
for the following situation:

gzip -dc linux-2.4.XX.tar.gz | tar zvf -
gzip -dc patchXX.gz | patch -p0

which may work, but note that patch can be a little tempremental about
the filenames it chooses from the patch file.  The absolute safest way
to apply a patch is:

gzip -dc linux-2.4.XX.tar.gz | tar zvf -
cd linux
gzip -dc patchXX.gz | patch -p1


--
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

Re: Possible README patch

[Anuradha Ratnaweera]

On Sat, 5 May 2001, Russell King wrote:

> gzip -dc linux-2.4.XX.tar.gz | tar zvf -
> gzip -dc patchXX.gz | patch -p0

This does _not_ work for international kernel patch. They assume the
directories lin.2.x.x/ (old) and int.2.x.x/ (new) and not linux/.
Therefore it _is_ necessary to `cd linux' and do a `patch -p1'.

Anuradha


----------------------------------------------------------
<a href="http://www.bee.lk/people/anuradha/">home page</a>

Re: Possible README patch

[Ralf Baechle]

On Thu, May 10, 2001 at 05:58:21PM +0600, Anuradha Ratnaweera wrote:
> Date: 	Thu, 10 May 2001 17:58:21 +0600 (LKT)
> From: Anuradha Ratnaweera <anuradha@gnu.org>
> To: Russell King <rmk@arm.linux.org.uk>
> cc: Duncan Gauld <duncan@gauldd.freeserve.co.uk>, linux-kernel@vger.kernel.org
> Subject: Re: Possible README patch
> 
> 
> On Sat, 5 May 2001, Russell King wrote:
> 
> > gzip -dc linux-2.4.XX.tar.gz | tar zvf -
> > gzip -dc patchXX.gz | patch -p0
> 
> This does _not_ work for international kernel patch. They assume the
> directories lin.2.x.x/ (old) and int.2.x.x/ (new) and not linux/.
> Therefore it _is_ necessary to `cd linux' and do a `patch -p1'.

Or patch -p0 -d linux.

  Ralf

Re: Possible README patch

[David S. Miller]

Anuradha Ratnaweera writes:
 > 
 > On Sat, 5 May 2001, Russell King wrote:
 > 
 > > gzip -dc linux-2.4.XX.tar.gz | tar zvf -
 > > gzip -dc patchXX.gz | patch -p0
 > 
 > This does _not_ work for international kernel patch. They assume the
 > directories lin.2.x.x/ (old) and int.2.x.x/ (new) and not linux/.
 > Therefore it _is_ necessary to `cd linux' and do a `patch -p1'.

Yes, but this document is about the official final patches Linus and
Alan release for 2.2.x and 2.4.x, not about arbitrary kernel patches
that are available.

Later,
David S. Miller
davem@redhat.com

Re: Possible README patch

[Albert D. Cahalan]

Duncan Gauld writes:

> Information in the README file says that when patching, the -p0 option is 
> used with patch (eg tar xvzf <patch>.tar.gz | patch -p0). However I have 
> never got this to work as I always get something like "can't find file to 
> patch at line 5". However, replacing -p0 with -p1 seems to work perfectly.
> Maybe the penguin doesn't like me, but still, whenever I've downloaded 
> patches I had to say -p1, not -p0...
...
> -- README	Sat May  5 09:51:36 2001
> +++ README	Sat May  5 09:52:24 2001
> @@ -66,10 +66,10 @@
>     install by patching, get all the newer patch files, enter the
>     directory in which you unpacked the kernel source and execute:

This is ambiguous:
"the directory in which you unpacked the kernel source"

If I do "cd /usr/src" then "tar Ixf linux-2.4.4.tar.bz2",
then where did I unpack the kernel source? I think you could
argue for /usr/src or /usr/src/linux equally well.