mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard Gooch <rgooch@ras.ucalgary.ca>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Getting FS access events
Date: Sun, 13 May 2001 23:15:58 -0600	[thread overview]
Message-ID: <200105140515.f4E5FwP10245@vindaloo.ras.ucalgary.ca> (raw)
In-Reply-To: <Pine.LNX.4.21.0105132139590.21224-100000@penguin.transmeta.com>
In-Reply-To: <200105140224.f4E2OiE08257@vindaloo.ras.ucalgary.ca> <Pine.LNX.4.21.0105132139590.21224-100000@penguin.transmeta.com>

Linus Torvalds writes:
> 
> On Sun, 13 May 2001, Richard Gooch wrote:
> > 
> > Think about it:-) You need to generate prefetch accesses in ascending
> > device bnum order.
> 
> I seriously doubt it is worth it.
> 
> Th ekernel will do the ordering for you anyway: that's what the
> elevator is, and that's why you have a "prefetch" system call (to
> avoid the synchronization that kills the elevator). And you'll end
> up wanting to pre-fetch on virtual addresses, which implies that you
> have to open the files: I doubt you want to have tons of files open
> and try to get a "global" order.

OK, provided the prefetch will queue up a large number of requests
before starting the I/O. If there was a way of controlling when the
I/O actually starts (say by having a START flag), that would be ideal,
I think.

> But sure, you can use bmap if you want. It would be interesting to
> hear whether it makes much of a difference..

I doubt bmap() would make any difference if there is a way of
controlling when the I/O starts.

However, this still doesn't address the issue of indirect blocks. If
the indirect block has a higher bnum than the data blocks it points
to, you've got a costly seek. This is why I'm still attracted to the
idea of doing this at the block device layer. It's easy to capture
*all* accesses and then warm the buffer cache.

So, why can't the page cache check if a block is in the buffer cache?

> > Sure, this would work too. I'm a bit worried about the increased
> > amount of traffic this will generate.
> 
> No increased traffic. "path" is a pointer (to a dentry), ie 32
> bits. "ino" is at least 128 bits on some filesystems. You make for _less_
> data to save.
> 
> > So on every page fault or read(2) call, we have to generate the full
> > path from the dentry? Isn't that going to add a fair bit of overhead?
> 
> You just save the dentry pointer. You do the path _later_, when
> somebody reads it away from the /proc file.

That opens up a nasty race: if the dentry is released before the
pointer is harvested, you get a bogus pointer.

> > I don't see the advantage of the prefetch(2) system call. It seems to
> > me I can get the same effect by just making read(2) calls in another
> > task. Of course, I'd need to use bmap() to generate the sort key, but
> > I don't see why that's a bad thing.
> 
> Try it. You won't be able to. "read()" is an inherently
> synchronizing operation, and you cannot get _any_ overlap with
> multiple reads, except for the pre-fetching that the kernel will do
> for you anyway.

How's that? It won't matter if read(2) synchronises, because I'll be
issuing the requests in device bnum order.

				Regards,

					Richard....
Permanent: rgooch@atnf.csiro.au
Current:   rgooch@ras.ucalgary.ca

  parent reply	other threads:[~2001-05-14  5:16 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200105140117.f4E1HqN07362@vindaloo.ras.ucalgary.ca>
2001-05-14  1:32 ` Linus Torvalds
2001-05-14  1:45   ` Larry McVoy
2001-05-14  2:39   ` Richard Gooch
2001-05-14  3:09     ` Rik van Riel
2001-05-14  4:27     ` Richard Gooch
2001-05-15  4:37     ` Chris Wedgwood
2001-05-23 11:37       ` Stephen C. Tweedie
2001-05-14  2:24 ` Richard Gooch
2001-05-14  4:46   ` Linus Torvalds
2001-05-14  5:15   ` Richard Gooch [this message]
2001-05-14 13:04     ` Daniel Phillips
2001-05-14 18:00       ` Andreas Dilger
2001-05-14 20:16     ` Linus Torvalds
2001-05-14 23:19     ` Richard Gooch
2001-05-15  0:42       ` Daniel Phillips
2001-05-15  4:00       ` Linus Torvalds
2001-05-15  4:35         ` Larry McVoy
2001-05-15  4:59           ` Alexander Viro
2001-05-15 17:01             ` Pavel Machek
2001-05-15  4:43         ` Linus Torvalds
2001-05-15  5:04           ` Alexander Viro
2001-05-15 16:17           ` Pavel Machek
2001-05-19 19:39             ` Linus Torvalds
2001-05-19 19:44               ` Pavel Machek
2001-05-19 19:47                 ` Linus Torvalds
2001-05-23 11:29                   ` Stephen C. Tweedie
2001-05-20  4:30               ` Chris Wedgwood
2001-05-20 19:47                 ` Alan Cox
2001-05-18  7:55           ` Rogier Wolff
2001-05-23 11:36             ` Stephen C. Tweedie
2001-05-15  4:57         ` David S. Miller
2001-05-15  5:12           ` Alexander Viro
2001-05-15  9:10           ` Alan Cox
2001-05-15  9:48             ` Lars Brinkhoff
2001-05-15  9:54               ` Alexander Viro
2001-05-15 20:17               ` Kai Henningsen
2001-05-15 20:58                 ` Alexander Viro
2001-05-15 21:08                   ` Alexander Viro
2001-05-15  6:20         ` Richard Gooch
2001-05-15  6:28           ` Linus Torvalds
2001-05-15  6:49           ` Richard Gooch
2001-05-15  6:57             ` Alexander Viro
2001-05-15 10:33               ` Daniel Phillips
2001-05-15 10:44                 ` Alexander Viro
2001-05-15 14:42                   ` Daniel Phillips
2001-05-15  7:13             ` Linus Torvalds
2001-05-15  7:56               ` Chris Wedgwood
2001-05-15  8:06                 ` Linus Torvalds
2001-05-15  8:33                   ` Alexander Viro
2001-05-15 10:27                     ` David Woodhouse
2001-05-15 16:00                     ` Chris Mason
2001-05-15 19:26                     ` H. Peter Anvin
2001-05-15 20:03                       ` Alexander Viro
2001-05-15 20:07                         ` H. Peter Anvin
2001-05-15 20:15                           ` Alexander Viro
2001-05-15 20:17                             ` H. Peter Anvin
2001-05-15 20:22                               ` Alexander Viro
2001-05-15 20:26                                 ` H. Peter Anvin
2001-05-15 20:31                                   ` Alexander Viro
2001-05-15 21:12                                     ` Linus Torvalds
2001-05-15 21:22                                     ` H. Peter Anvin
2001-05-15 21:02                                 ` Linus Torvalds
2001-05-15 21:53                                   ` Jan Harkes
2001-05-19  5:26                   ` Chris Wedgwood
2001-05-15 10:04             ` Anton Altaparmakov
2001-05-15 19:28               ` H. Peter Anvin
2001-05-15 22:31                 ` Albert D. Cahalan
2001-05-15 22:35                   ` H. Peter Anvin
2001-05-16  1:17                   ` Anton Altaparmakov
2001-05-16  1:30                     ` H. Peter Anvin
2001-05-16  8:34                     ` Anton Altaparmakov
2001-05-16 16:27                       ` H. Peter Anvin
2001-05-15 16:26             ` Pavel Machek
2001-05-15 18:02             ` Craig Milo Rogers
2001-05-15  6:13       ` Richard Gooch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200105140515.f4E5FwP10245@vindaloo.ras.ucalgary.ca \
    --to=rgooch@ras.ucalgary.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®