[PATCH] compiler warning fix in aci.c

[PATCH] compiler warning fix in aci.c

[Anuradha Ratnaweera]

Following patch fixes a compiler warning in aci.c.

Regards,

Anuradha

----------------------------------
http://www.bee.lk/people/anuradha/


diff -rua linux-2.4.5/drivers/sound/aci.c linux/drivers/sound/aci.c
--- linux-2.4.5/drivers/sound/aci.c	Tue May 29 23:42:11 2001
+++ linux/drivers/sound/aci.c	Wed May 30 01:21:14 2001
@@ -95,18 +95,6 @@
 MODULE_PARM_DESC(wss,"change between ACI/WSS-mixer; use 0 and 1 - untested"
 		 " default: do nothing; for PCM1-pro only");
 
-static void print_bits(unsigned char c)
-{
-	int j;
-	printk(KERN_DEBUG "aci: ");
-
-	for (j=7; j>=0; j--) {
-		printk(KERN_DEBUG "%d", (c >> j) & 0x1);
-	}
-
-	printk(KERN_DEBUG "\n");
-}
-
 /*
  * This busy wait code normally requires less than 15 loops and
  * practically always less than 100 loops on my i486/DX2 66 MHz.

Re: [PATCH] compiler warning fix in aci.c

[Anuradha Ratnaweera]

On Wed, 30 May 2001, Anuradha Ratnaweera wrote:

> Following patch fixes a compiler warning in aci.c.

I can guess the usefullness of the functiion print_bits that would be
removed if my patch is applied. If this is so, how about putting it inside
an "#ifdef DEBUG"?

Regards,

Anuradha

----------------------------------
http://www.bee.lk/people/anuradha/

Re: [PATCH] compiler warning fix in aci.c

[Robert Siemer]

From: Anuradha Ratnaweera <anuradha@gnu.org>
> On Wed, 30 May 2001, Anuradha Ratnaweera wrote:
> 
> > Following patch fixes a compiler warning in aci.c.
> 
> I can guess the usefullness of the functiion print_bits that would be
> removed if my patch is applied. If this is so, how about putting it
> inside an "#ifdef DEBUG"?

This is exactly what I did some month ago with my little working tree.

Anyway: are you using some aci-supported hardware? Which one?


Bye,
	Robert

PS: I'm not subscribed to linux-kernel.

Re: [PATCH] compiler warning fix in aci.c

[Anuradha Ratnaweera]

On Wed, 30 May 2001, Robert Siemer wrote:

> From: Anuradha Ratnaweera <anuradha@gnu.org>
>
> > On Wed, 30 May 2001, Anuradha Ratnaweera wrote:
> > 
> > > Following patch fixes a compiler warning in aci.c.
> > 
> > I can guess the usefullness of the functiion print_bits that would be
> > removed if my patch is applied. If this is so, how about putting it
> > inside an "#ifdef DEBUG"?
> 
> This is exactly what I did some month ago with my little working tree.

So will you be adding the "#ifdef" again?
 
> Anyway: are you using some aci-supported hardware? Which one?

No. I just compiled a kernel with a generic .config and noticed the
compiler warning.

Regards,

Anuradha

----------------------------------
http://www.bee.lk/people/anuradha/

Re: [PATCH] compiler warning fix in aci.c

[Robert Siemer]

From: Anuradha Ratnaweera <anuradha@gnu.org>
> On Wed, 30 May 2001, Robert Siemer wrote:

> > > > Following patch fixes a compiler warning in aci.c.

> > > ... how about putting it inside an "#ifdef DEBUG"?
> > 
> > This is exactly what I did some month ago with my little working
> > tree.
> 
> So will you be adding the "#ifdef" again?

My next kernel patch for the aci will do so, or I'll remove some
debugging code. - In any case I'll pay more attention to compiler
warnings.

As I'm currently short of time it will take some weeks...
(The next patch will also include more RDS/RBDS code for the miroSOUND
PCM20 radio)

Bye,
	Robert