mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kuznet@ms2.inr.ac.ru
To: therapy@endorphin.org (clemens)
Cc: pekkas@netcore.fi, therapy@endorphin.org, netdev@oss.sgi.com,
	linux-kernel@vger.kernel.org, davem@redhat.com
Subject: Re: missing icmp errors for udp packets
Date: Tue, 31 Jul 2001 23:04:06 +0400 (MSK DST)	[thread overview]
Message-ID: <200107311904.XAA10312@ms2.inr.ac.ru> (raw)
In-Reply-To: <20010731205101.B8211@ghanima.endorphin.org> from "clemens" at Jul 31, 1 08:51:01 pm

Hello!

> your patch will not prevent the first ping to empty the token bucket,
> because burst is still 0, which is larger than dst->rate_token, and since
> XRLIM_BURST_FACTOR times the timeout (which is 6*0=0 in that case) is the
> token maximum, it will be truncated to 0,
> causing the following packets (if in time) to be dropped.

Argh... I see, gap is too short and not enough of tokens are accumulated.
Thank you.

Damn, I see two ways: 1. to make sysctl active function
and recalculate max/sum of rates over classes and fill bucket.

Or to remove limiting distinguishing types, which is ideal
logically.

Alexey

  reply	other threads:[~2001-07-31 19:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.33.0107290739370.2081-100000@netcore.fi>
2001-07-29 15:59 ` kuznet
2001-07-30 13:03   ` Pekka Savola
2001-07-31 18:33     ` kuznet
2001-07-31 18:47       ` Pekka Savola
2001-07-31 18:51       ` clemens
2001-07-31 19:04         ` kuznet [this message]
2001-07-31 19:23           ` Chris Wedgwood
2001-07-31 19:25             ` kuznet
2001-07-31 19:34               ` Chris Wedgwood
2001-07-31 19:37                 ` kuznet
2001-07-31 19:41                   ` Chris Wedgwood
2001-07-31 19:59                     ` Pekka Savola
2001-07-31 20:53                       ` Chris Wedgwood
2001-07-31 20:57                         ` Pekka Savola
2001-08-02 19:31     ` Pekka Savola
2001-08-03  8:58     ` David S. Miller
     [not found] <200107311857.WAA10162@ms2.inr.ac.ru>
2001-07-31 20:16 ` clemens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200107311904.XAA10312@ms2.inr.ac.ru \
    --to=kuznet@ms2.inr.ac.ru \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    --cc=pekkas@netcore.fi \
    --cc=therapy@endorphin.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®