From: <jes@trained-monkey.org>
To: sebastien.rougeaux@anu.edu.au
Cc: Gord Peters <GordPeters@smarttech.com>,
torvalds@transmeta.com, alan@redhat.com,
linux-kernel@vger.kernel.org
Subject: [patch] 64 bit bug in ohci1394.c
Date: Thu, 16 Aug 2001 00:42:33 -0400 [thread overview]
Message-ID: <200108160442.f7G4gXT19513@savage.trained-monkey.org> (raw)
Hi
drivers/ieee1394/ohci1394.c has a couple of instances where it saved
cpu flags in 'int' which breaks on 64 bit boxes.
Here's a patch.
Jes
--- drivers/ieee1394/ohci1394.c~ Wed Aug 8 00:08:04 2001
+++ drivers/ieee1394/ohci1394.c Thu Aug 16 00:40:28 2001
@@ -200,7 +200,8 @@
static u8 get_phy_reg(struct ti_ohci *ohci, u8 addr)
{
- int i, flags;
+ int i;
+ unsigned long flags;
quadlet_t r;
spin_lock_irqsave (&ohci->phy_reg_lock, flags);
@@ -227,7 +228,8 @@
static void set_phy_reg(struct ti_ohci *ohci, u8 addr, u8 data)
{
- int i, flags;
+ int i;
+ unsigned long flags;
u32 r;
spin_lock_irqsave (&ohci->phy_reg_lock, flags);
@@ -1066,7 +1068,8 @@
quadlet_t event, node_id;
struct ti_ohci *ohci = (struct ti_ohci *)dev_id;
struct hpsb_host *host = ohci->host;
- int phyid = -1, isroot = 0, flags;
+ int phyid = -1, isroot = 0;
+ unsigned long flags;
/* Read the interrupt event register. We don't clear the bus reset
* here. We wait till we get a selfid complete interrupt and clear
@@ -1331,7 +1334,8 @@
struct ti_ohci *ohci = (struct ti_ohci*)(d->ohci);
unsigned int split_left, idx, offset, rescount;
unsigned char tcode;
- int length, bytes_left, ack, flags;
+ int length, bytes_left, ack;
+ unsigned long flags;
quadlet_t *buf_ptr;
char *split_ptr;
char msg[256];
next reply other threads:[~2001-08-16 4:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-16 4:42 jes [this message]
2001-08-16 4:44 jes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200108160442.f7G4gXT19513@savage.trained-monkey.org \
--to=jes@trained-monkey.org \
--cc=GordPeters@smarttech.com \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastien.rougeaux@anu.edu.au \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®